Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 427791

Summary:	Pushing to a URL containing a user name does not work.
Product:	[ECD] Orion	Reporter:	Stefan Lay <stefan.lay>
Component:	Git	Assignee:	Stefan Lay <stefan.lay>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn
Version:	unspecified
Target Milestone:	5.0 RC1
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:

Description Stefan Lay

2014-02-10 07:53:49 EST

When I want to push to a repository URL which contains my user name (like https://slay@git.eclipse.org/r/egit/egit-github), I only get an input field for the password. When I enter my password and select Submit, the push fails, and the password dialog stays.

I analyzed further and saw, that the username is not contained in the json sent to the server. The server coding however only takes the user name from the json payload but not the user name from the URL (GitRemoteHandlerV1.handlePost:  GitUtils.createGitCredentialsProvider(requestObject)).

The client already knows the username, so I propose that the client sends it to the server also in this case.

Comment 1 Stefan Lay

2014-02-10 08:33:53 EST

Patch proposed at https://git.eclipse.org/r/#/c/21750/

Comment 2 Matthias Sohn

2014-02-11 06:31:47 EST

merged as 8ef8abc7eda8505aedde0cbacbda755c4fa16096