Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 427759

Summary:

[terminal] Hyperlink detection should be supported

Product:

[ECD] Orion

Reporter:

Chris McGee <sirnewton_01>

Component:

Client

Assignee:

Anthony Hunter <ahunter.eclipse>

Status:

RESOLVED NOT_ECLIPSE

QA Contact:

Severity:

normal

Priority:

CC:

ahunter.eclipse, grant_gayed

Version:

5.0

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Proposed patch	none

Description Chris McGee

2014-02-09 21:27:58 EST

It would be great if the docker shell could detect hyperlinks in the output much like how many xterm emulators can do. If a tool provides a hyperlink then the user can simply click on it open a new browser tab on that location.

Comment 1 Chris McGee

2014-02-09 21:34:26 EST

Created attachment 239772 [details]
Proposed patch

This patch detects certain http(s)/(s)ftp/telnet links as long as they don't have any exotic characters and don't cross lines.

Comment 2 Anthony Hunter

2014-03-13 16:37:27 EDT

Hi Chris, this patch looks good to me as far as I can tell. However, you are patching the third party library term.js.

You need to make this contribution to the term.js project and not Orion. We can then pick this up the next time we get the latest term.js.

The project is hosted at GitHub at https://github.com/chjj/term.js/

Comment 3 Anthony Hunter

2014-03-25 14:26:40 EDT

Hi Chris, can you reopen this defect when the term.js project has accepted your contribution?