Bugzilla – Full Text Bug Listing
| Summary: | Cached theme data gets out of sync | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> | ||||
| Component: | Client | Assignee: | Mark Macdonald <mamacdon> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | ken_walker, mamacdon, Silenio_Quarti | ||||
| Version: | 5.0 | Flags: | ken_walker:
review+
Silenio_Quarti: review+ |
||||
| Target Milestone: | 5.0 RC3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Well I fixed the Orion theme and the CSS file so they're consistent with the Orion2014 theme. And I made the banner in the old (Orion) theme look reasonable. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=9eb080a But I'm keeping this bug open because the general problem still exists. I'll try to describe the problem more clearly: * Mike is an Orion 4.0 user * Mike's browser has Orion-4.0 theme data cached in localStorage * Mike loads Orion 5.0, which has major UI/style changes * Orion 5.0 displays using his cached, stale theme data * Orion 5.0 looks like trash. We need to version the cached theme data. At page load time, a version mismatch must download fresh theme data (should be equivalent to visiting Orion with an empty localStorage). When an Orion developer makes style changes to any themeable elements, they must increment the version number. For testing: here's a reproducible way to get into the bad state I described in Comment 1: 1. Load an Orion page, then open your browser's JavaScript console. 2. Copy/paste the following chunk of code into the console and press enter: localStorage['/orion/preferences/local/themes'] = JSON.parse(atob(""{\"styles\":\"[{\\\"name\\\":\\\"Orion\\\",\\\"navbar\\\":\\\"#404648\\\",\\\"button\\\":\\\"#EFEFEF\\\",\\\"location\\\":\\\"#efefef\\\",\\\"selection\\\":\\\"FEC\\\",\\\"sidepanel\\\":\\\"#FBFBFB\\\",\\\"mainpanel\\\":\\\"white\\\",\\\"toolpanel\\\":\\\"white\\\",\\\"navtext\\\":\\\"#bfbfbf\\\",\\\"content\\\":\\\"#3087B3\\\",\\\"search\\\":\\\"#444\\\",\\\"breadcrumb\\\":\\\"#3087B3\\\",\\\"separator\\\":\\\"#333\\\"},{\\\"name\\\":\\\"Green Zone\\\",\\\"navbar\\\":\\\"seagreen\\\",\\\"button\\\":\\\"lavender\\\",\\\"location\\\":\\\"darkseagreen\\\",\\\"selection\\\":\\\"moccasin\\\",\\\"sidepanel\\\":\\\"aliceblue\\\",\\\"mainpanel\\\":\\\"white\\\",\\\"toolpanel\\\":\\\"white\\\",\\\"navtext\\\":\\\"#FBFBFB\\\",\\\"content\\\":\\\"darkgreen\\\",\\\"search\\\":\\\"darkgreen\\\",\\\"breadcrumb\\\":\\\"#3087B3\\\",\\\"separator\\\":\\\"seagreen\\\"},{\\\"name\\\":\\\"Pretty In Pink\\\",\\\"navbar\\\":\\\"plum\\\",\\\"button\\\":\\\"lavender\\\",\\\"location\\\":\\\"pink\\\",\\\"selection\\\":\\\"lavender\\\",\\\"sidepanel\\\":\\\"seashell\\\",\\\"mainpanel\\\":\\\"white\\\",\\\"toolpanel\\\":\\\"white\\\",\\\"navtext\\\":\\\"#FBFBFB\\\",\\\"content\\\":\\\"mediumorchid\\\",\\\"search\\\":\\\"violet\\\",\\\"breadcrumb\\\":\\\"#3087B3\\\",\\\"separator\\\":\\\"plum\\\"},{\\\"name\\\":\\\"Blue Monday\\\",\\\"navbar\\\":\\\"cornflowerblue\\\",\\\"button\\\":\\\"lavender\\\",\\\"location\\\":\\\"skyblue\\\",\\\"selection\\\":\\\"lavender\\\",\\\"sidepanel\\\":\\\"aliceblue\\\",\\\"mainpanel\\\":\\\"white\\\",\\\"toolpanel\\\":\\\"white\\\",\\\"navtext\\\":\\\"#FBFBFB\\\",\\\"content\\\":\\\"royalblue\\\",\\\"search\\\":\\\"royalblue\\\",\\\"breadcrumb\\\":\\\"#3087B3\\\",\\\"separator\\\":\\\"cornflowerblue\\\"},{\\\"name\\\":\\\"Vanilla Skies\\\",\\\"navbar\\\":\\\"sandybrown\\\",\\\"button\\\":\\\"lemmonchiffon\\\",\\\"location\\\":\\\"cornsilk\\\",\\\"selection\\\":\\\"lemonchiffon\\\",\\\"sidepanel\\\":\\\"white\\\",\\\"mainpanel\\\":\\\"white\\\",\\\"toolpanel\\\":\\\"white\\\",\\\"navtext\\\":\\\"lemonchiffon\\\",\\\"content\\\":\\\"chocolate\\\",\\\"search\\\":\\\"moccasin\\\",\\\"breadcrumb\\\":\\\"#3087B3\\\",\\\"separator\\\":\\\"sandybrown\\\"},{\\\"name\\\":\\\"Beetlejuice\\\",\\\"navbar\\\":\\\"indigo\\\",\\\"button\\\":\\\"slateblue\\\",\\\"location\\\":\\\"darkslateblue\\\",\\\"selection\\\":\\\"silver\\\",\\\"sidepanel\\\":\\\"lavender\\\",\\\"mainpanel\\\":\\\"white\\\",\\\"toolpanel\\\":\\\"white\\\",\\\"navtext\\\":\\\"#FBFBFB\\\",\\\"content\\\":\\\"mediumslateblue\\\",\\\"search\\\":\\\"#444\\\",\\\"breadcrumb\\\":\\\"#3087B3\\\",\\\"separator\\\":\\\"indigo\\\"},{\\\"name\\\":\\\"Red\\\",\\\"navbar\\\":\\\"#CD2127\\\",\\\"button\\\":\\\"#777777\\\",\\\"location\\\":\\\"#D85F56\\\",\\\"selection\\\":\\\"lightcoral\\\",\\\"sidepanel\\\":\\\"#EFDAB2\\\",\\\"mainpanel\\\":\\\"#FDFADD\\\",\\\"toolpanel\\\":\\\"#FDFADD\\\",\\\"navtext\\\":\\\"#FBFBFB\\\",\\\"content\\\":\\\"darkred\\\",\\\"search\\\":\\\"#D85F56\\\",\\\"breadcrumb\\\":\\\"darkred\\\",\\\"separator\\\":\\\"#CD2127\\\"}]\",\"selected\":\"{\\\"selected\\\":\\\"Orion\\\",\\\"editorSelected\\\":\\\"Prospecto\\\"}\",\"editorstyles\":\"[{\\\"name\\\":\\\"Eclipse\\\",\\\"annotationRuler\\\":\\\"white\\\",\\\"background\\\":\\\"white\\\",\\\"comment\\\":\\\"green\\\",\\\"keyword\\\":\\\"#7f0055\\\",\\\"text\\\":\\\"darkSlateGray\\\",\\\"string\\\":\\\"blue\\\",\\\"overviewRuler\\\":\\\"white\\\",\\\"lineNumberOdd\\\":\\\"#444\\\",\\\"lineNumberEven\\\":\\\"#444\\\",\\\"lineNumber\\\":\\\"#444\\\",\\\"currentLine\\\":\\\"#EAF2FE\\\",\\\"tag\\\":\\\"darkorange\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"},{\\\"name\\\":\\\"Prospecto\\\",\\\"annotationRuler\\\":\\\"white\\\",\\\"background\\\":\\\"white\\\",\\\"comment\\\":\\\"#3C802C\\\",\\\"keyword\\\":\\\"#CC4C07\\\",\\\"text\\\":\\\"#333\\\",\\\"string\\\":\\\"#446FBD\\\",\\\"overviewRuler\\\":\\\"white\\\",\\\"lineNumberOdd\\\":\\\"silver\\\",\\\"lineNumberEven\\\":\\\"silver\\\",\\\"lineNumber\\\":\\\"silver\\\",\\\"currentLine\\\":\\\"#EAF2FE\\\",\\\"tag\\\":\\\"#CC4C07\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"},{\\\"name\\\":\\\"Blue\\\",\\\"annotationRuler\\\":\\\"lavender\\\",\\\"background\\\":\\\"aliceBlue\\\",\\\"comment\\\":\\\"indigo\\\",\\\"keyword\\\":\\\"cornFlowerBlue\\\",\\\"text\\\":\\\"navy\\\",\\\"string\\\":\\\"cornFlowerBlue\\\",\\\"overviewRuler\\\":\\\"lavender\\\",\\\"lineNumberOdd\\\":\\\"darkSlateGray\\\",\\\"lineNumberEven\\\":\\\"darkSlateGray\\\",\\\"lineNumber\\\":\\\"darkSlateGray\\\",\\\"currentLine\\\":\\\"white\\\",\\\"tag\\\":\\\"cornFlowerBlue\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"},{\\\"name\\\":\\\"Ambience\\\",\\\"annotationRuler\\\":\\\"#3D3D3D\\\",\\\"background\\\":\\\"#202020\\\",\\\"comment\\\":\\\"mediumslateblue\\\",\\\"keyword\\\":\\\"cornFlowerBlue\\\",\\\"text\\\":\\\"darkseagreen\\\",\\\"string\\\":\\\"lightcoral\\\",\\\"overviewRuler\\\":\\\"white\\\",\\\"lineNumberOdd\\\":\\\"black\\\",\\\"lineNumberEven\\\":\\\"black\\\",\\\"lineNumber\\\":\\\"black\\\",\\\"currentLine\\\":\\\"lightcyan\\\",\\\"tag\\\":\\\"cornFlowerBlue\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"},{\\\"name\\\":\\\"Tierra\\\",\\\"annotationRuler\\\":\\\"moccasin\\\",\\\"background\\\":\\\"lemonchiffon\\\",\\\"comment\\\":\\\"darkseagreen\\\",\\\"keyword\\\":\\\"darkred\\\",\\\"text\\\":\\\"#555555\\\",\\\"string\\\":\\\"orangered\\\",\\\"overviewRuler\\\":\\\"moccasin\\\",\\\"lineNumberOdd\\\":\\\"chocolate\\\",\\\"lineNumberEven\\\":\\\"chocolate\\\",\\\"lineNumber\\\":\\\"chocolate\\\",\\\"currentLine\\\":\\\"#baa289\\\",\\\"tag\\\":\\\"darkred\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"},{\\\"name\\\":\\\"Nimbus\\\",\\\"annotationRuler\\\":\\\"#444\\\",\\\"background\\\":\\\"dimgray\\\",\\\"comment\\\":\\\"darkseagreen\\\",\\\"keyword\\\":\\\"darkorange\\\",\\\"text\\\":\\\"white\\\",\\\"string\\\":\\\"cornflowerblue\\\",\\\"overviewRuler\\\":\\\"#444\\\",\\\"lineNumberOdd\\\":\\\"#aaa\\\",\\\"lineNumberEven\\\":\\\"#aaa\\\",\\\"lineNumber\\\":\\\"#aaa\\\",\\\"currentLine\\\":\\\"#aabfbb\\\",\\\"tag\\\":\\\"darkorange\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"},{\\\"name\\\":\\\"Adelante\\\",\\\"annotationRuler\\\":\\\"#E2D2B2\\\",\\\"background\\\":\\\"#F1E7C8\\\",\\\"comment\\\":\\\"#5D774E\\\",\\\"keyword\\\":\\\"#AF473B\\\",\\\"text\\\":\\\"dimgray\\\",\\\"string\\\":\\\"#DE5D3B\\\",\\\"overviewRuler\\\":\\\"#E2D2B2\\\",\\\"lineNumberOdd\\\":\\\"#AF473B\\\",\\\"lineNumberEven\\\":\\\"#AF473B\\\",\\\"lineNumber\\\":\\\"#AF473B\\\",\\\"currentLine\\\":\\\"#9e937b\\\",\\\"tag\\\":\\\"#AF473B\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"},{\\\"name\\\":\\\"Raspberry Pi\\\",\\\"annotationRuler\\\":\\\"seashell\\\",\\\"background\\\":\\\"seashell\\\",\\\"comment\\\":\\\"#66B32F\\\",\\\"keyword\\\":\\\"#E73E36\\\",\\\"text\\\":\\\"dimgray\\\",\\\"string\\\":\\\"darkorange\\\",\\\"overviewRuler\\\":\\\"seashell\\\",\\\"lineNumberOdd\\\":\\\"#E73E36\\\",\\\"lineNumberEven\\\":\\\"#E73E36\\\",\\\"lineNumber\\\":\\\"#E73E36\\\",\\\"currentLine\\\":\\\"#F5B1AE\\\",\\\"tag\\\":\\\"#E73E36\\\",\\\"attribute\\\":\\\"cadetBlue\\\",\\\"fontFamily\\\":\\\"\\\\\\\"Consolas\\\\\\\", \\\\\\\"Monaco\\\\\\\", \\\\\\\"Vera Mono\\\\\\\", \\\\\\\"monospace\\\\\\\"\\\",\\\"fontSize\\\":\\\"10pt\\\"}]\"}"")); ^ This sets your cached theme data to Orion 4.0 styles. 5. Reload the Orion page 6. You'll see a grey banner. This is the bug. I added a version field to ThemeData. Just before the cached theme is applied, we check its version. If it does not match the current version, we overwrite the cached data with the current theme data. It seems to work fine. However, in the case where you do have stale theme info, there's a noticeable flicker that happens a moment after the page loads, as the styling corrects itself. It's not ideal. See Comment 2 for instructions on how to test the patch. The expected behavior after the fix is that you get the white banner. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c1e0ea9 Adding reviewers. Silenio, let me know if you're too busy and I'll find an alternate. Looks fine. |
Created attachment 239749 [details] bad banner bg For users that used an Orion website (like orion.eclipse.org) prior to Orion 5.0, they will have theme choice saved in their browser localStorage that does not match the Orion 5.0 styles. The theme they probably have stored is named "Orion" but the current theme is "Orion2014". Once you get in this state, the top banner's bgcolor can appear grey (see pic). This happened to Mike. Need to fix the Orion theme to have the correct banner color. Also, the banner color in theme.css is wrong too. We're relying on the theme engine to dynamically inject the correct color from the Orion2014 and override the wrong color.