Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 427665

Summary:	Maximize editor broken
Product:	[ECD] Orion	Reporter:	John Arthorne <john.arthorne>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	Mike_Wilson, Silenio_Quarti
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John Arthorne

2014-02-07 09:18:51 EST

Build: I20140206-2230

Ctrl+Shift+M is the command to maximize the editor. With the new UI changes, it is not currently working. It should hide the new bar on the left hand side, and the menu bar.

Comment 1 Silenio Quarti

2014-02-07 10:14:34 EST

The command says hide banner and footer and that is what is happening.

We need to decided whether the side menu and menu bar should be hidden as well.

In the old UI, the SideMenu functionality was hidden because it was accessible from the banner.  So it makes sense for me to hide it. But the menu bar functionality was not. The left and right toolbars were still available when maximized.

Comment 2 John Arthorne

2014-02-10 12:19:01 EST

Ok good point, hiding the menu is debatable. I think it should hide the left side stuff though to give all the horizontal space to the editor.

Comment 3 Mike Wilson

2014-06-25 18:51:36 EDT

I think hiding the side bar is debatable too. As Silenio says, the operation does what it claims to: it hides the header and footer. Leaving the side bar in place means that you're not just stuck in the editor, you get all of the Orion pages. (Of course, for that to make sense we should keep the "hide header and footer" state the same as you transition from page to page. Today, as soon as you click on something in the side bar, the header and footer re-appear on the new page.)

In any case, since...
- the operation does what it says it does
- we decided the menu should stay,
- if you really need to you can manually close the left bar by clicking on its thumb
... I'm closing this as won't fix. 

If we get to the point where we're reworking the UI (yet again) and people feel strongly that it should have the other behaviour then we can re-open this bug or create a new one.