Bugzilla – Full Text Bug Listing
| Summary: | Some pages missing Edit, Shell icons in Navigation Menu | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Client | Assignee: | Mark Macdonald <mamacdon> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 5.0 | ||
| Target Milestone: | 5.0 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
We'll need some more support from the SideMenu before the static page links can be used instead -- designating a default link for the category, so that the 2 page links (Workspace and top-level Shell) will only be shown when nothing more relevant is available. This will prevent the confusing case where the generic top-level Editor and Shell links appear alongside more interesting links. Now they will just be last-ditch appearances to ensure that a path exists between the various Orion pages, whatever your state may be. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=926f473 Merged. The static page links for edit.html and shell.html are back, now shown only when there's no other links in the edit or shell categories (respectively) to show instead. |
After my recent meddling with the Navigation menu, the following pages have lost the Edit (pencil) and Shell icons: * Git Repositories * Sites This makes it hard to get back to the editor page. I expect to see an editor link, and a shell link. ASIDE: The global Search page *does* have an editor icon (labeled "Workspace"), because its page target is set to { NoTarget: "" }. NoTarget is the special hack that activates certain related links when the page does not have any specific File context to validate related links against otherwise. There are only 2 contributed links that reference NoTarget in their validationProperties: * Editor Workspace link (mentioned above) * Shell link AFAICT, NoTarget was used rather than a static page link (orion.page.link) based on the assumption that related links are rendered in a separate content area away from page links, and we didn't want the related links area to ever appear empty. That assumption no longer holds, so we should delete the NoTarget hacks and just rely on static "orion.page.link" to get to the editor.