Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 427601

Summary:	Drag and drop from desktop to tree problems
Product:	[ECD] Orion	Reporter:	Anton McConville <antonm>
Component:	Client	Assignee:	Elijah El-Haddad <elijahe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Mike_Wilson, Silenio_Quarti
Version:	unspecified	Flags:	Silenio_Quarti: review+
Target Milestone:	5.0 RC1
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Anton McConville

2014-02-06 15:25:12 EST

Mcq observed some problems with drag and drop:

- when he dragged a folder over the dropzone, the dropzone vanished but gave no feedback that it couldn't open the unzipped folder

- mcq dragged a zipped folder directly into the workspace, the folder opened, but the project name was lost

Comment 1 Silenio Quarti

2014-02-06 15:53:12 EST

(In reply to Anton McConville from comment #0)
> Mcq observed some problems with drag and drop:
> 
> - when he dragged a folder over the dropzone, the dropzone vanished but gave
> no feedback that it couldn't open the unzipped folder

I have not seen this problem

> - mcq dragged a zipped folder directly into the workspace, the folder
> opened, but the project name was lost

This one is fixed by:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4d77f6b90e0b93ce5e7de1f60bbc7ac6e07a20d4

Comment 2 Elijah El-Haddad

2014-02-06 16:45:02 EST

(In reply to Anton McConville from comment #0)
> Mcq observed some problems with drag and drop:
> 
> - when he dragged a folder over the dropzone, the dropzone vanished but gave
> no feedback that it couldn't open the unzipped folder
> 
> - mcq dragged a zipped folder directly into the workspace, the folder
> opened, but the project name was lost


I was able to reproduce the first scenario: "when he dragged a folder over the dropzone, the dropzone vanished but gave no feedback that it couldn't open the unzipped folder". This happens when the drop target contains a folder of the same name. Looking into displaying an error message now.

Comment 3 Elijah El-Haddad

2014-02-06 17:17:23 EST

(In reply to Elijah El-Haddad from comment #2)
> (In reply to Anton McConville from comment #0)
> > Mcq observed some problems with drag and drop:
> > 
> > - when he dragged a folder over the dropzone, the dropzone vanished but gave
> > no feedback that it couldn't open the unzipped folder
> > 
> > - mcq dragged a zipped folder directly into the workspace, the folder
> > opened, but the project name was lost
> 
> 
> I was able to reproduce the first scenario: "when he dragged a folder over
> the dropzone, the dropzone vanished but gave no feedback that it couldn't
> open the unzipped folder". This happens when the drop target contains a
> folder of the same name. Looking into displaying an error message now.

Fix pushed to github: 
- Show error message if dropping a folder fails
https://github.com/elijahe/orion.client/commit/56bef211c3aef2541cb93910835350cf65b84ec3

Comment 4 Elijah El-Haddad

2014-02-06 17:24:00 EST

(In reply to Elijah El-Haddad from comment #3)
> Fix pushed to github: 
> - Show error message if dropping a folder fails
> https://github.com/elijahe/orion.client/commit/
> 56bef211c3aef2541cb93910835350cf65b84ec3

Pushed to eclipse.org by Silenio

Comment 5 Elijah El-Haddad

2014-02-06 17:24:26 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f88e6cefd23da93b4953f0aa322cb8d1ec731f9e