Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 427575

Summary:	Gerrit: Enable Push for Review
Product:	[ECD] Orion	Reporter:	Stefan Lay <stefan.lay>
Component:	Git	Assignee:	Stefan Lay <stefan.lay>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	maciej.bendkowski, matthias.sohn
Version:	unspecified
Target Milestone:	5.0 RC1
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:
Bug Depends on:
Bug Blocks:	425233

Description Stefan Lay

2014-02-06 11:12:07 EST

Currently it is not possible to push to Gerrit into the review queue. After pressing the Push button the user can open a Dialog with the "More" button and enter a branch name. The server prepends "refs/heads" to the entered branch name.

It should be possible to enter refs/for/<branchname> into this dialog. Additionally it would be nice if there were a dedicated "Push for Review" button. This button could be shown only if the remote repository is hosted on Gerrit (This could be specified by the config setting gerrit.createchangeid).

Comment 1 Stefan Lay

2014-02-06 11:25:22 EST

Pushed for review:

https://git.eclipse.org/r/#/c/21628/ (client part)
https://git.eclipse.org/r/#/c/21631/ (server part)

Comment 2 Matthias Sohn

2014-02-08 19:22:00 EST

(In reply to Stefan Lay from comment #1)
> Pushed for review:
> 
> https://git.eclipse.org/r/#/c/21628/ (client part)
merged as 17cbab4e68445b4e6b412a68e333295b9356c25b

> https://git.eclipse.org/r/#/c/21631/ (server part)
merged as a5f7d2a9d0e515d646b65d5408b99b288e5099d7

thanks for this nice improvement :-)