Bugzilla – Full Text Bug Listing
| Summary: | [publisher] Stale profile files in org.eclipse.equinox.p2.publisher | ||
|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Tobias Oberlies <t-oberlies> |
| Component: | p2 | Assignee: | Tobias Oberlies <t-oberlies> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | david_williams, irbull, tjwatson |
| Version: | unspecified | ||
| Target Milestone: | Mars M4 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 250003, 386013, 426841, 437923 | ||
|
Description
Tobias Oberlies
As predicted, the org.eclipse.equinox.p2.publisher yet again has a stale list of profile files: It is missing the new compact profiles. This copying nonsense has to stop - the publisher really should just take the profiles from org.eclipse.osgi, like everybody else (see e.g. [1]) [1] http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/tycho-core/src/main/java/org/eclipse/tycho/core/ee/ExecutionEnvironmentUtils.java As a temporary workaround, I've copied the profile files again. This change has been pushed to master and R4_4_maintenance, so it should be included in 4.4 SR1. Proposed a change to fix the root cause: https://git.eclipse.org/r/#/c/32850/ This change shall only be submitted to master. This change is being included in our RC4 build and there was no notification to the platform releng list or the dev lists. Was it really the intention to include this change right at the last build for SR1? Are we certain the change will not introduce some regression at this point? Is someone going to do the necessary p2 testing to make sure SR1 is ready? Up to this point no changes had been done in p2 for SR1. I've reverted d38c783 [1]. Since we are into RC4 and there was no review or announcment about this change, the end-game rules won't allow this. [1] http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?h=R4_4_maintenance&id=5dda21273e2d03169883b0b9d15cdc5eef0451c5 (In reply to comment #4) > Was it really the intention to include this change right at the last build for SR1? No, I simply didn't manage to do it earlier. > Are we certain the change will not introduce some regression at this point? > Is someone going to do the necessary p2 testing to make sure SR1 is ready? The automatic tests passed [1], and manual tests with Tycho using the changed publisher bundle also passed. (In reply to comment #5) > Since we are into RC4 and there was no review or announcement about this > change, the end-game rules won't allow this. Do you have a link to a wiki page with these rules? AFAIK, there is no developer's guide for p2. [1] https://hudson.eclipse.org/p2/job/p2-maintenance/1/ (In reply to Tobias Oberlies from comment #6) > (In reply to comment #4) > > Was it really the intention to include this change right at the last build for SR1? > No, I simply didn't manage to do it earlier. > > > Are we certain the change will not introduce some regression at this point? > > Is someone going to do the necessary p2 testing to make sure SR1 is ready? > The automatic tests passed [1], and manual tests with Tycho using the > changed publisher bundle also passed. > > (In reply to comment #5) > > Since we are into RC4 and there was no review or announcement about this > > change, the end-game rules won't allow this. > > Do you have a link to a wiki page with these rules? AFAIK, there is no > developer's guide for p2. > > [1] https://hudson.eclipse.org/p2/job/p2-maintenance/1/ Sorry for the confusing Tobias. Since Equinox builds and releases closely with the Eclipse project we also use the Eclipse project rampdown plan: http://www.eclipse.org/eclipse/development/plans/freeze_plan_4_3_1.php I do think it is good to get these profiles updated in p2 and I appreciate the work you have done here, but it is too late for SR1 at this point. Lets plan to do this for SR2. (In reply to comment #7) > I do think it is good to get these profiles updated in p2 and I appreciate the > work you have done here, but it is too late for SR1 at this point. Lets plan to > do this for SR2. Given that we missed SR1, we are probably going for Mars M2 in the next Tycho milestone release. So we don't need to do anything for SR2. @Thomas: What do you think of the proposal of deleting the redundant copies of the profile files [1]? I'm tired of running into the problem that they are outdated again and again. [1] https://git.eclipse.org/r/#/c/32850/ (In reply to Tobias Oberlies from comment #8) > (In reply to comment #7) > > I do think it is good to get these profiles updated in p2 and I appreciate the > > work you have done here, but it is too late for SR1 at this point. Lets plan to > > do this for SR2. > Given that we missed SR1, we are probably going for Mars M2 in the next > Tycho milestone release. So we don't need to do anything for SR2. > > @Thomas: What do you think of the proposal of deleting the redundant copies > of the profile files [1]? I'm tired of running into the problem that they > are outdated again and again. > > [1] https://git.eclipse.org/r/#/c/32850/ I think that is a good idea for Mars, but lets plan for M3? You already updated the copies for M2. (In reply to comment #9) > I think that is a good idea for Mars, but lets plan for M3? Hmm, M3 is almost over again. So, to do the change in M4, do I simply wait until the end of next week (i.e. after M3+0) and submit the change then? (In reply to Tobias Oberlies from comment #10) > (In reply to comment #9) > > I think that is a good idea for Mars, but lets plan for M3? > Hmm, M3 is almost over again. > > So, to do the change in M4, do I simply wait until the end of next week > (i.e. after M3+0) and submit the change then? Yeah, lets do this as soon as M3 is announced. Should be end of next week. |