Bugzilla – Full Text Bug Listing
| Summary: | Unexternalized strings for Getting Started | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Kit Lo <kitlo> | ||||||
| Component: | Server | Assignee: | Project Inbox <orion.server-inbox> | ||||||
| Status: | RESOLVED WONTFIX | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ahunter.eclipse, maciej.bendkowski, mamacdon | ||||||
| Version: | 5.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 239444 [details]
Getting Started dialog
Proposed fix https://git.eclipse.org/r/#/c/22088/ Proposed fix https://git.eclipse.org/r/#/c/22088/ The proposed fix loads message bundles directly from plugin code (pageLinksPlugin). This is not going to work (see here: https://wiki.eclipse.org/Orion/Internationalization#Plugins ) Instead we must add support for translation to the "orion.page.getstarted" service. pageLinksPlugin should provide a "nls" bundle and "labelKey" field, and the UATaskPanel should be responsible for loading the bundle and looking up the translated string for the labelKey. (In reply to Mark Macdonald from comment #4) > Instead we must add support for translation to the "orion.page.getstarted" > service. pageLinksPlugin should provide a "nls" bundle and "labelKey" field, > and the UATaskPanel should be responsible for loading the bundle and looking > up the translated string for the labelKey. As for this particular bug the suggested solution is fine, I think we're missing a more general case of external plugin string externalization. The current il18n framework puts the responsibility of loading translation bundles on the plugin consumer. Moreover, the plugin has no notion of "current locale" and can't obtain it from Orion. I'll open a separate bug for this discussion. The getting started dialog and menu no longer exists. |
Created attachment 239443 [details] Getting Started menu