Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 426934

Summary:	Investigate visiting Identifier nodes in occurrences support
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	curtis.windatt.public
Version:	5.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Michael Rennie

2014-01-29 13:51:39 EST

Currently our mark occurrences code looks ahead to find identifiers - for example:

case Estraverse.Syntax.AssignmentExpression:
  this.checkId(node.left);
  this.checkId(node.right);
  break;

Instead of looking ahead and later visiting / ignoring the same Identifier node we find during the look-ahead, what if we only visited Identifier nodes? There are of course exceptions to this, like the ThisExpression, which does not have an Identifer node, and places where we need to compute scopes: ObjectExpression, Function(Declaration/Expression).

Comment 1 Michael Rennie

2014-04-08 15:04:44 EDT

Closing as wontfix - there are many places we now use some of the parent node infos as cues for scoping / etc while finding occurrences