Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 426806

Summary: I_XXX_CommandFactory.setAutoRefreshD_YYY_() methods have no effect and should be removed
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: CoreAssignee: Maxime Porhel <maxime.porhel>
Status: CLOSED FIXED QA Contact: Pierre-Charles David <pierre-charles.david>
Severity: normal    
Priority: P3 CC: maxime.porhel
Version: 1.0.0M5Keywords: triaged
Target Milestone: 1.0.0M6   
Hardware: PC   
OS: All   
Whiteboard:

Description Pierre-Charles David CLA 2014-01-28 10:36:44 EST 
The only concrete class implementing the interface is UndoRedoCapableEMFCommandFactory, but it does not implement the setAutoRefreshDView() method. The "implementation" is just:

// TODO Feature not implemented.

The method should be removed from the API, along with any related code.
Comment 1 Pierre-Charles David CLA 2014-01-29 04:17:54 EST 
Reviewed by Maxime and merged as commit 4f352912ad8313bb41771f2e5b8a20b5025d4f67.
Comment 2 Maxime Porhel CLA 2014-02-06 10:10:37 EST 
The work has been done and merged for IDiagramCommandFactory.setAutoRefreshDView().

The same work should be done for: 
. ITableCommandFactory.setAutoRefreshDTable()
. ITreeCommandFactory.setAutoRefreshDTree()
Comment 3 Maxime Porhel CLA 2014-03-06 06:05:44 EST 
See https://git.eclipse.org/r/#/c/22965/ for changes on ITableCommandFactory and ITreeCommandFactory
Comment 4 Maxime Porhel CLA 2014-03-06 10:58:44 EST 
Reviewed by Laurent and merged as commit https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=44e6b21f8916764e87640f796f6739af34938060
Comment 5 Maxime Porhel CLA 2014-03-07 05:37:54 EST 
Verified as a technical issue on 1.0.0-N20140306-1631 nightly build.
Comment 6 Maxime Porhel CLA 2014-03-10 06:53:29 EDT 
An issue was found in our automated tests: some preference listener fileds should have been removed.

See correction in https://git.eclipse.org/r/23115
Comment 8 Pierre-Charles David CLA 2014-03-10 09:50:30 EDT 
Verified in the code.
Comment 9 Pierre-Charles David CLA 2014-03-17 10:07:07 EDT 
Available in Sirius 1.0.0M6 (see https://wiki.eclipse.org/Sirius/1.0.0M6).