Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 426319

Summary: Gerrit Hudson CI verification build does not pick the current patch set
Product: [RT] RAP Reporter: Ivan Furnadjiev <ivan>
Component: RelengAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: mknauer
Version: 2.3   
Target Milestone: 2.3 M1   
Hardware: All   
OS: All   
Whiteboard:

Description Ivan Furnadjiev CLA 2014-01-22 03:15:18 EST 
The change https://git.eclipse.org/r/20850 passed the Hudson CI verification, but broke the nightly build - see https://hudson.eclipse.org/rap/job/rap-head-runtime/129/
Today I pushed a change https://git.eclipse.org/r/20923 to fix the broken build, but Hudson CI verification does not pick the patch set. It failed with the error related to the previous change https://git.eclipse.org/r/20850. It seems that the build is executed against master and not against current change branch.
Comment 1 Markus Knauer CLA 2014-01-22 05:12:45 EST 
Collecting some information...

Job rap-head-runtime https://hudson.eclipse.org/rap/job/rap-head-runtime/

Failed  #130 	22-Jan-2014 01:34:17	Revision: 1d7e25e1c9de79ae24880912f542131a62e12746
Failed  #129 	21-Jan-2014 19:31:17	Revision: 1d7e25e1c9de79ae24880912f542131a62e12746
Success  #128 	20-Jan-2014 19:31:17	Revision: 10bb1eb8cfab5c11fe9f59b473aadfd8e6a066dd
Success  #127 	19-Jan-2014 19:31:17	Revision: 37d6817d8e93543760cc1d3101d1e5f681ccbcd3

Job rap-head-runtime-gerrit https://hudson.eclipse.org/rap/job/rap-head-runtime-gerrit/

Failed  #45 	22-Jan-2014 02:56:03	Revision: 1d7e25e1c9de79ae24880912f542131a62e12746 20923,1
Failed  #44 	22-Jan-2014 02:43:26	Revision: 1d7e25e1c9de79ae24880912f542131a62e12746 20923,1
Success  #43 	21-Jan-2014 08:13:32	Revision: 10bb1eb8cfab5c11fe9f59b473aadfd8e6a066dd 20850,2
Success  #42 	21-Jan-2014 02:38:47	Revision: 10bb1eb8cfab5c11fe9f59b473aadfd8e6a066dd 20850,1

Change 20850 (Change-Id: I43ad09e0b7e00a08b3be8758f6d269370a16327b)
Patch Set 1 ccfeefef7f9d929fae1f21f21b5cb4d2f51b8eb9 Parent 10bb1eb8cfab5c11fe9f59b473aadfd8e6a066dd
Patch Set 2 1d7e25e1c9de79ae24880912f542131a62e12746 Parent 10bb1eb8cfab5c11fe9f59b473aadfd8e6a066dd

Change 20923 (Change-Id: I1a6f59a47a128c0914fdcc05eee6b8d6a749d5d3)
Patch Set 1 0aded2b846d5aafbe8fe87281766c068f3d6125e Parent 1d7e25e1c9de79ae24880912f542131a62e12746
Comment 2 Markus Knauer CLA 2014-01-22 12:10:39 EST 
According to http://wiki.eclipse.org/Gerrit#Configuration_of_Git_plugin: '**' should be used as a value for "Branches to build". I always thought that this looks a bit suspicious [1], but we were using it in accordance to the doc anyway. I changed this to '$GERRIT_PATCHSET_REVISION' now which sound more logical and solves the problem.


[1] Hudson documentation: 'If you specify "**" all branches will be examined for changes and branch with last changes will be used to build.'
Comment 3 Markus Knauer CLA 2014-01-22 12:17:40 EST 
Addendum: Another possible solution is to use '**' for the branches, but set the Git choosing strategy to 'Gerrit Trigger' instead of 'default'. I will try this another time.