Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 426069

Summary:	New ruby/php/python syntax highlighting issues
Product:	[ECD] Orion	Reporter:	Ken Walker <ken_walker>
Component:	Client	Assignee:	Grant Gayed <grant_gayed>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	gabriel.luong
Version:	5.0
Target Milestone:	5.0 M2
Hardware:	All
OS:	All
Whiteboard:

Description Ken Walker

2014-01-19 20:04:51 EST

In code if you have something in a Ruby file like:
# Set up gems listed in the Gemfile.

The "#" section is not treated like a comment and
the "in" is considered a keyword and highlighted as such

Comment 1 Grant Gayed

2014-01-20 10:03:27 EST

I'm going to take this and do a pass over the basic structures for all three languages.

Comment 2 Gabriel Luong

2014-01-20 11:11:39 EST

I want to do some more additional languages. Any recommendations on the next priorities?

Comment 3 Grant Gayed

2014-01-20 11:18:34 EST

YAML was another that McQ brought up, you can take Bug 423861 to work on it.  Beyond this one there weren't others specifically called out.  Ken any thoughts?

Comment 4 Grant Gayed

2014-01-21 17:06:03 EST

I've pushes fixes for all of the major issues:

- Bug 426285 was needed in order to properly support ruby's =begin/=end comment notation
- Ruby improvements: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4fda8c03672bb551a4a00ba79b092ba9506d2ab7 and http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fc4720308fa3e375547a49c9e938169fdf70f0e2
- PHP, Python, and <?php...%> embedding of PHP in HTML: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1e58618dc2426ef1e4558cf75817460a52a34b1c

Still todo:
- PHP heredoc and nowdoc comment notations (dependent on Bug 426304)
- more HTML embedding notations

Comment 5 Grant Gayed

2014-01-22 15:47:14 EST

The comment 4 todo's have been addressed in the commits below, so closing report as FIXED > 20140122.  New reports should be logged for problems found with these stylings.

- PHP heredoc and nowdoc: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4c02bfb33a8f90aaec5aec6bc0f4f758d71c8c0d
- improved HTML embedding of PHP: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c9af51ecb8dde2aa1f695847e33cdd5cc9384314