Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 425943

Summary: JSONURIUnqualificationStrategy can cause problems for Git
Product: [ECD] Orion Reporter: Bogdan Gheorghe <gheorghe>
Component: ServerAssignee: Bogdan Gheorghe <gheorghe>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, simon_kaegi, Szymon.Brandys
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Bogdan Gheorghe CLA 2014-01-16 18:08:45 EST
Our current JSONURIUnqualificationStrategy which is used by OrionServlet to write responses, causes problems for git servers that run on the same server (real or virtual) as Orion.

Git urls should never be unqualified - they currently are which breaks most git functionality after the initial clone.
Comment 2 Bogdan Gheorghe CLA 2014-01-16 18:21:22 EST
Still need to refactor TaskInfo to allow users to specify what kind of UnqualificationStrategy to use during updates. Currently we sort of do this by having a setLocation() on TaskInfo - it would be good to change that to setStrategy().
Comment 3 Simon Kaegi CLA 2014-01-16 23:21:19 EST
First the whole URIUnqualification thing is a bit of a mess and due for cleanup hower I'd like to understand more about what you're doing here. The URLs that we expose through our git api should not expose internal server names. Perhaps that's not an issue here but we should review this.
Comment 4 John Arthorne CLA 2015-05-05 14:37:31 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html