Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 425922

Summary:	Unanticipated comparator error in M20140116-0900
Product:	[Eclipse Project] Equinox	Reporter:	David Williams <david_williams>
Component:	Launcher	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	VERIFIED FIXED	QA Contact:	Arun Thondapu <arunkumar.thondapu>
Severity:	blocker
Priority:	P3	CC:	arunkumar.thondapu, daniel_megert, Silenio_Quarti
Version:	3.9.0 Kepler
Target Milestone:	Kepler SR2
Hardware:	PC
OS:	Linux
Whiteboard:

Description David Williams

2014-01-16 13:00:27 EST

See 
http://download.eclipse.org/eclipse/downloads/drops4/M20140116-0900/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

I marked as "blocker", since appears that is in the "delivered" build, is not what was intended ... and I'm assuming it is a blocker. Feel free to adjust if it really is not. 

The messages I'm concerned about are the ones like 

1.  rt.equinox.framework/bundles/org.eclipse.equinox.launcher.gtk.linux.x86
   no-classifier: different
      META-INF/ECLIPSE_.RSA: different
      META-INF/ECLIPSE_.SF: different
      eclipse_1506.so: present in baseline only
      eclipse_1508.so: not present in baseline
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [pack200]

These imply 'eclipse_1508' was the new one intended to be in RC1, but since "qualifier" did not change, the older 'eclipse_1506' was "swap in" to the delivered build.

Comment 1 Silenio Quarti

2014-01-16 13:13:06 EST

Arun, we need to touch some file for all the launcher bundles/fragments. This used to happen for free because the commitBinaries task in the releng project would change the build.properties file to update the binaryTag (see [1] for an example).  One option is to touch the build.properties manually, but I think the easiest way is to add back the code that updates the binaryTag (even though it is not used anymore) (see [2]).

[1] http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?h=R3_9_maintenance&id=d1b8b8e6f633a4bfa75d0fc7e48f2a68ff0fa669

[2] http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/releng/org.eclipse.equinox.launcher.releng/build.xml?id=72c26472b6269957b427fbc4b5251d5f3d047745

Comment 2 David Williams

2014-01-16 16:20:31 EST

To be explicit ... You all will say "ready" when ready, right? Hope that wasn't supposed to be obvious and you all are waiting on me?

Comment 3 Silenio Quarti

2014-01-16 17:22:11 EST

I have fixed the R3_9_maintenance branch so that the build can be done.

Arun, still need to make the same change in build.xml to master.

Comment 4 Silenio Quarti

2014-01-16 17:26:21 EST

(In reply to Silenio Quarti from comment #3)
> I have fixed the R3_9_maintenance branch so that the build can be done.
> 
> Arun, still need to make the same change in build.xml to master.

Here is the fix:

http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?h=R3_9_maintenance&id=6051efb7bb5211553af670d1af7f6e34c986ad18

Comment 5 Arun Thondapu

2014-02-06 13:27:39 EST

(In reply to Silenio Quarti from comment #3)
> I have fixed the R3_9_maintenance branch so that the build can be done.
> 
> Arun, still need to make the same change in build.xml to master.

https://git.eclipse.org/r/#/c/21646/ - Silenio, here is the patch for build.xml changes in master. Can you please review and push? Thanks!

Comment 6 Silenio Quarti

2014-02-06 14:40:49 EST

done

Comment 7 Arun Thondapu

2014-02-07 01:42:15 EST

Resolved in all M-builds after M20140116-0900