| Summary: | Make sure all known app manifests are supported | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> |
| Component: | Deployment | Assignee: | Maciej Bendkowski <maciej.bendkowski> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | unspecified | ||
| Target Milestone: | 5.0 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 425959 | ||
|
Description
Szymon Brandys
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=85bb50a735f34c9d4e383ae7bfd8fcd32caa07dc : Added support for ${target-base} and ${random-word} ruby symbols Maciek confirmed that push works for known cases. I tested it with some applications hosted on JazzHub and GitHub. For instance: https://github.com/jarthorn/bluemix-node-sample-twitter-search-analyzer-app.git was deployed correctly, however there is problem starting it in Orion, but also cli https://hub.jazz.net/project/srich/Sentiment%20Analysis%20App was not deployed properly. Maciek, please take a look. Also I had to change the project structure and modify manifest.yml file to be able to even try to deploy to CF. We need to rethink how to deploy apps which are not in the root of the Orion project. See Bug 426051. (In reply to Szymon Brandys from comment #2) > https://hub.jazz.net/project/srich/Sentiment%20Analysis%20App was not > deployed properly. Maciek, please take a look. After changing the project structure I was able to deploy without further manifest.yml modifications. From my point of view, there's nothing wrong with the manifest itself, however we should support non-trivial project structures, as mentioned in bug 426051. http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=6ec66d3267440863914c0bd32ffe57067a8a48b2 - Added support for the 'path' property (In reply to Maciej Bendkowski from comment #4) > http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/ > ?id=6ec66d3267440863914c0bd32ffe57067a8a48b2 - Added support for the 'path' > property The 'path' support had to be reverted as it introduced a regression. It shall be fixed soon. Fixed 'path' support with http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=1a2e05c914dca5faa730fc9a4f4bf55e5d073e57 I think we can close this general bug and raise new ones per case. |