Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 425437

Summary: content assist tests failing on master
Product: [ECD] Orion Reporter: Manu Sridharan <m.sridharan>
Component: JS ToolsAssignee: Elijah El-Haddad <elijahe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: elijahe, mamacdon
Version: unspecified   
Target Milestone: 5.0 M2   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Manu Sridharan CLA 2014-01-10 13:40:27 EST 
Nearly all the content assist regression tests in bundles/org.eclipse.orion.client.javascript/web/js-tests/contentAssistTests.js are now failing on master.  This is due to commit d00774537f, which changed the formatting of the assist proposals.  Probably the "right" fix for this would be to change the content assist tests to do less string matching and more checking of data structure values, and hence be less dependent on formatting.
Comment 1 Elijah El-Haddad CLA 2014-01-13 09:34:46 EST 
Fix pushed to github repo. Please review and push to master if appropriate.

- Adapted contentAssistTests to expect new Javascript proposal format which extracts the name from the proposal description.
- Passed in option to not include non-inferred proposals since the tests don't expect them.
https://github.com/elijahe/orion.client/commit/78f9585ee44b49cb5548449d91775aa113a4f96c