Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 425280

Summary:	WAR build failed if there are spaces in repo path
Product:	[RT] RAP	Reporter:	Ivan Furnadjiev <ivan>
Component:	Releng	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mknauer
Version:	2.1
Target Milestone:	2.3 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Ivan Furnadjiev

2014-01-10 06:56:02 EST

If RAP repo is in a path with spaces, the build failed with exception:
---
[ERROR] Internal error: java.lang.RuntimeException: Invalid repository URL: file:E:\EclipseSource\Git Repositories\org.e
clipse.rap\releng\org.eclipse.rap.examples.build\rapdemo\feature/../../localrepo: Illegal character in opaque part at in
dex 25: file:E:/EclipseSource/Git Repositories/org.eclipse.rap/releng/org.eclipse.rap.examples.build/rapdemo/feature/../
../localrepo -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: Invalid repository URL: file:E:\Ecl
ipseSource\Git Repositories\org.eclipse.rap\releng\org.eclipse.rap.examples.build\rapdemo\feature/../../localrepo
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: java.lang.RuntimeException: Invalid repository URL: file:E:\EclipseSource\Git Repositories\org.eclipse.rap\re
leng\org.eclipse.rap.examples.build\rapdemo\feature/../../localrepo
        at org.eclipse.tycho.p2.resolver.P2TargetPlatformResolver.addEntireP2RepositoryToTargetPlatform(P2TargetPlatform
Resolver.java:319)
        at org.eclipse.tycho.p2.resolver.P2TargetPlatformResolver.computeTargetPlatform(P2TargetPlatformResolver.java:20
1)
        at org.eclipse.tycho.core.resolver.DefaultTychoDependencyResolver.resolveProject(DefaultTychoDependencyResolver.
java:100)
        at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.afterProjectsRead(TychoMavenLifecycleParticipant.
java:82)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:274)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
        ... 11 more
Caused by: java.net.URISyntaxException: Illegal character in opaque part at index 25: file:E:/EclipseSource/Git Reposito
ries/org.eclipse.rap/releng/org.eclipse.rap.examples.build/rapdemo/feature/../../localrepo
        at java.net.URI$Parser.fail(URI.java:2829)
        at java.net.URI$Parser.checkChars(URI.java:3002)
        at java.net.URI$Parser.parse(URI.java:3039)
        at java.net.URI.<init>(URI.java:595)
        at java.net.URL.toURI(URL.java:938)
        at org.eclipse.tycho.p2.resolver.P2TargetPlatformResolver.addEntireP2RepositoryToTargetPlatform(P2TargetPlatform
Resolver.java:311)
        ... 16 more

Comment 1 Markus Knauer

2014-03-07 07:12:32 EST

The problem is the 'localrepo' p2 repository that was introduced for bundles that cannot be hosted at eclipse.org. These additional/optional bundles can be added to this 'localrepo' and the build will pick them up from there. As far as I know we don't use this any more (or have never been using it in the past). I think the best way to move forward would be to remove this repository from the parent-parent-pom and adjust product definitions and the readme.md accordingly.

Comment 2 Ivan Furnadjiev

2014-03-07 07:17:44 EST

(In reply to Markus Knauer from comment #1)
> I think the best way to move forward would be to remove this
> repository from the parent-parent-pom and adjust product definitions and the
> readme.md accordingly.
+1

Comment 3 Markus Knauer

2014-03-07 08:21:52 EST

Committed in change https://git.eclipse.org/r/23039