Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 424507

Summary: Blame button sometimes requires to clicks to show blame in Chrome
Product: [ECD] Orion Reporter: Chris McGee <cbmcgee>
Component: EditorAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, Silenio_Quarti
Version: 4.0   
Target Milestone: 5.0 M2   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Chris McGee CLA 2013-12-19 19:21:41 EST 
Sometimes it seems that the Blame button at the top of the editor needs to be clicked twice before showing the annotations. It seems to happen alot with the latest Chrome browser.
Comment 1 Ken Walker CLA 2013-12-19 19:24:54 EST 
The feature may take some time depending on the size of the file.  Is this a small file?
Comment 2 Chris McGee CLA 2013-12-19 19:58:46 EST 
That's true. Some files do take a while to generate the blame. However, I don't get any error message or anything even after 30-40 seconds in this case. I tried opening up the chrome developer tools and I don't see the network request in the Network section. When I click the blame again I can see the request.
Comment 3 Ken Walker CLA 2013-12-19 20:27:36 EST 
Right, that would be a long time.  I wonder if we can somehow use the task service or display something to indicate it's doing something so you know.
Comment 4 Silenio Quarti CLA 2013-12-26 13:42:30 EST 
The problem would happen when the editor input file changed while the blame annotations were visible. The boolean that determined if the blame annotations were visible would get stale.

Fixed

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=250d1a0291e011afcd4f7d5f858d5d9ac6d8ef68