Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 424422

Summary: Add Underline and Strike as new options on label format style
Product: [Modeling] Sirius Reporter: Melanie Bats <melanie.bats>
Component: DiagramAssignee: Melanie Bats <melanie.bats>
Status: CLOSED FIXED QA Contact: Laurent Fasani <laurent.fasani>
Severity: enhancement    
Priority: P3 CC: belqassim.djafer, esteban.dugueperoux, laurent.fasani, laurent.redor, maxime.porhel, pierre-charles.david
Version: 1.0.0M4Keywords: triaged
Target Milestone: 3.0.0   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/39650
https://git.eclipse.org/r/39949
https://git.eclipse.org/r/39649
https://git.eclipse.org/r/39950
https://git.eclipse.org/r/46693
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7e48d91962f6f4eff3599469bb6b1ee2f7228def
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ecdfe17e35aa9e6c802adfbca9767a0959266950
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0310bf9e08bd6a301b4ef012445c65df9025a2e7
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f8061e370b1f84329fcdecac18639fad1363dada
https://git.eclipse.org/r/48133
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5e61db13634ad4553de3d97db07fbadfebd813e4
https://git.eclipse.org/r/48148
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c57883d1d2586910dd7652f08b2b83f0f84ed94b
https://git.eclipse.org/r/48180
https://git.eclipse.org/r/48246
https://git.eclipse.org/r/48294
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3289622101ce4dccd07a1202fc1a59624d80977c
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=58f7eb77baad2ab05b079c60bedad3a9d382aef6
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f93c3a36603e1793ccb1b92f6a26e7a81d0159ca
https://git.eclipse.org/r/48479
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0777e16daa1cd2735caccfc773e2612aafc9aa05
https://git.eclipse.org/r/48592
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9907ed0e5fabb260a4d3a535ae4acbc6a752f666
Whiteboard:
Attachments:
Description Flags
Label format
none
Migration test
none
Sample project for homologation none

Description Melanie Bats CLA 2013-12-19 05:10:36 EST
Created attachment 238472 [details]
Label format

In the label style definition, is it possible to add two more options to the Label Format. It already exists 'Bold' and 'Italic', I expect to get also 'Underline' and 'Strike'.
Comment 1 Laurent Redor CLA 2013-12-23 08:05:29 EST
Indeed, these options are available in the Appearance properties view but not available in VSM.
Comment 2 Melanie Bats CLA 2015-01-15 05:56:38 EST
Just to inform you that I am working on a patch for this feature, I will send it soon.
Comment 3 Eclipse Genie CLA 2015-04-28 11:15:19 EDT
New Gerrit change created: https://git.eclipse.org/r/46693
Comment 8 Eclipse Genie CLA 2015-05-19 04:46:00 EDT
New Gerrit change created: https://git.eclipse.org/r/48133
Comment 10 Eclipse Genie CLA 2015-05-19 05:56:05 EDT
New Gerrit change created: https://git.eclipse.org/r/48148
Comment 12 Eclipse Genie CLA 2015-05-19 10:38:52 EDT
New Gerrit change created: https://git.eclipse.org/r/48180
Comment 13 Eclipse Genie CLA 2015-05-20 04:26:20 EDT
New Gerrit change created: https://git.eclipse.org/r/48246
Comment 14 Eclipse Genie CLA 2015-05-20 11:47:48 EDT
New Gerrit change created: https://git.eclipse.org/r/48294
Comment 18 Laurent Redor CLA 2015-05-22 07:47:42 EDT
This issue is now completed with some automatic tests for table and tree (comment 16).
Comment 19 Maxime Porhel CLA 2015-05-22 11:01:43 EDT
Belqassim detected that the Table migration participant does not migrate the table styles.
Comment 20 Belqassim Djafer CLA 2015-05-22 11:05:56 EDT
Created attachment 253692 [details]
Migration test

The migration participant added for this change does not work correctly.
To reproduce, import the attached project and try to open "2270.odesign" -> KO: IllegalValueException: Value 'bold_italic' is not legal.
Comment 21 Eclipse Genie CLA 2015-05-22 11:57:47 EDT
New Gerrit change created: https://git.eclipse.org/r/48479
Comment 23 Pierre-Charles David CLA 2015-05-22 15:10:26 EDT
I've merged Maxime's new migration code, but we should also add a test for the cases which are now handled by this versions and were not before; none of our existing tests identified the problem.
Comment 24 Eclipse Genie CLA 2015-05-26 04:17:05 EDT
New Gerrit change created: https://git.eclipse.org/r/48592
Comment 26 Maxime Porhel CLA 2015-05-26 11:23:22 EDT
The migration has been corrected and a migration test added.
Comment 27 Pierre-Charles David CLA 2015-06-24 11:12:35 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.
Comment 28 Esteban DUGUEPEROUX CLA 2016-01-04 05:27:14 EST
Created attachment 258979 [details]
Sample project for homologation

I have attached a sample project for validation.