Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 424366

Summary: NPE in GitCloneHandlerV1.isAccessAllowed
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: GitAssignee: John Arthorne <john.arthorne>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: unspecified   
Target Milestone: 5.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2013-12-18 14:00:34 EST 
I201312172230

There are many errors like this in the orion.eclipse.org server log:

java.lang.NullPointerException
        at org.eclipse.orion.server.git.servlets.GitCloneHandlerV1.isAccessAllowed(GitCloneHandlerV1.java:428)
        at org.eclipse.orion.server.git.servlets.GitCloneHandlerV1.handleGet(GitCloneHandlerV1.java:283)
        at org.eclipse.orion.server.git.servlets.GitCloneHandlerV1.handleRequest(GitCloneHandlerV1.java:68)
        at org.eclipse.orion.server.git.servlets.GitCloneHandlerV1.handleRequest(GitCloneHandlerV1.java:1)
        at org.eclipse.orion.server.git.servlets.GitHandlerV1.handleRequest(GitHandlerV1.java:68)
        at org.eclipse.orion.server.git.servlets.GitHandlerV1.handleRequest(GitHandlerV1.java:1)
Comment 1 John Arthorne CLA 2013-12-18 14:01:46 EST 
From the search indexer log I believe it is caused by this same case where Mark has a workspace that contains a project, but the project does not exist:

java.lang.RuntimeException: Unexpected missing project with name ð© in workspace mamacdon-OrionContent
        at org.eclipse.orion.internal.server.search.Indexer.indexWorkspace(Indexer.java:155)


I have unlinked this project from Mark's workspace to make the root cause go away. We should still have a null check in this git code to avoid the NPE.