Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 424263

Summary: Find file named and search files dialog can be opened at the same time
Product: [ECD] Orion Reporter: Curtis Windatt <curtis.windatt.public>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: libingw
Version: 5.0   
Target Milestone: 5.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Curtis Windatt CLA 2013-12-17 13:27:52 EST 
1) Ctrl-Shift-F to open find file dialog
2) Start typing to get results
3) Ctrl-H to open search files dialog
4) Start typing to get results
Result:
Text starts filling in both text boxes, but selecting and editing the text cannot be done. The cursor appears to be below the text box.  Clicking on any result doesn't open the file.
Comment 1 libing wang CLA 2013-12-17 16:43:39 EST 
This is more like a generic issue.
I do not think we should even allow two modal dialogs appear from the same parent. That says you can still open another modal dialog from a modal dialog though.

We need to rethink about the implementation of dialog.js.
Comment 2 libing wang CLA 2013-12-23 14:33:15 EST 
Although not a perfect solution but we may want a modal dialog manager globally.
1. It should make sure there is only one dialog opened whose parent is the document DIV.
2. There are other cases where multiple modal dialogues appear, e.g., the site editor case. But those dialogues should be opened from within the parent dialogues.
Comment 3 libing wang CLA 2013-12-24 12:45:18 EST 
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e79a92f02fc391cf8e2c278bb012ed19925fe008.

Now only one modal dialog can appear at a time unless there is a child modal dialog.
Currently, site editor, git clone dialog and SFTP connection command have one level child modal dialogs. I've tested those cases as well.
Comment 4 libing wang CLA 2013-12-30 14:56:32 EST 
refactor the modal dialog manager into dialog.js with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=203a4490b68cf0f7359fa36eb6eeaa00be8f8617