| Summary: | multi-line strings are not recognized when initially typed | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> |
| Component: | Client | Assignee: | Grant Gayed <grant_gayed> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 5.0 | ||
| Target Milestone: | 5.0 M2 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Grant Gayed
(re-purposing this report, the old problem is fixed as a side-effect of another fix, but a different problem is observed) Multi-line strings work fine if they're already in a document when it is loaded. However typing a new multi-line string does not work. The editor does not get its auto-indentation right, and the styler just leaves it plain. Not sure if there's an editor issue here or not. Note that this does not happen (by luck) when at the very end of the file. textStyler.computeBlocks() computes the first line of the multi-line string to be the block, which is fine, but then a change on the next line is considered to be outside of that block, so the block is not considered at all in the resulting re-style. This perhaps made sense specifically for multi-line comments which had a definite terminator (*/), but multi-line string blocks grow as chars are appended to their end. Fixed > 20140117, commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2aad88fd7a5a204321d9da7bc460c9dcac8d033c . |