Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423929

Summary:	syntax highlight patterns need ability to include other patterns
Product:	[ECD] Orion	Reporter:	Grant Gayed <grant_gayed>
Component:	Client	Assignee:	Grant Gayed <grant_gayed>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	5.0
Target Milestone:	5.0 M2
Hardware:	PC
OS:	All
Whiteboard:

Description Grant Gayed

2013-12-12 10:59:44 EST

- for embedded language cases (eg.- js within html)
- would make definitions of new languages easier if they have similarities to existing ones (eg.- JS, JSON, Java are all "c-like")

Comment 1 Grant Gayed

2013-12-12 11:01:50 EST

Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bcd95ed2810b85d531c95807c6fef1b9b364b12c (not marking as fixed until embedded languages case has been verified).

Comment 2 Grant Gayed

2013-12-18 15:32:27 EST

This is mostly working, but one case to be addressed is blocks within blocks (eg.- a <script> block containing a JS /*...*/ block).

Comment 3 Grant Gayed

2013-12-18 16:36:41 EST

Bracket matching is also not working.

Comment 4 Grant Gayed

2013-12-18 17:12:27 EST

TODO annotations too (they highlight fine but do not appear in the gutter).

Comment 5 Grant Gayed

2013-12-24 13:12:13 EST

Comment 2 and comment 3 are now fixed, each block (multi-line match) now has its own context that contains its specific match patterns, etc.  Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c764a4a162d1e774921f8a55b14e5e0efd6201de .

Comment 4 is still not working but it appears that the correct annotation creation is now happening as a result of this change, so there's a different issue here.  Will investigate and log a new report for this if warranted.