Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423894

Summary:	[EditorMgmt][Split editor] Focus lost / commands broken after splitting editor
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Eric Moffatt <emoffatt>
Status:	VERIFIED FIXED	QA Contact:	Eric Moffatt <emoffatt>
Severity:	major
Priority:	P3	CC:	cvgaviao, daniel.rolka, daniel_megert, fredrik.attebrant, Lars.Vogel, lech, pelder.eclipse
Version:	4.4
Target Milestone:	4.4 M6
Hardware:	All
OS:	All
Whiteboard:

Description Markus Keller

2013-12-12 06:10:22 EST

I20131210-2000 Mac; seems to work on Windows

To work around bug 423893, assign different key bindings to the Split editor commands. Then open a Java Editor and split it.

The focus is lost. Should be in the left/top editor.

Comment 1 Markus Keller

2013-12-12 06:14:27 EST

When I click into the editor text, the editor tab looks like the editor is active, but most commands don't work and menus are not available (e.g. Refactor for a Java editor).

Comment 2 Markus Keller

2013-12-12 06:26:07 EST

Commands are also broken on Windows after playing around a bit

Comment 3 Lars Vogel

2013-12-12 06:59:05 EST

Example for the lost shortcuts: If I create a new Class and change the name in the editor, e.g. from Test to "Tesst" I cannot involve Ctrl+1 directly. I need to set focus on another part and select the splitted editor again to make shortcuts work again.

Comment 4 Dani Megert

2013-12-17 07:07:01 EST

Simple test case:
1. open a text file
2. split it
3. make the 'Package Explorer' the active part by clicking into it
4. click into the split editor
==> key bindings are all gone

Comment 5 Dani Megert

2013-12-17 07:07:31 EST

Also some of the main menus are gone.

Comment 6 Christoph Lechleitner

2013-12-18 06:25:27 EST

These focus and shortcut problems are present under Linux GTK x64 (4.4M4), too.

Still, I'm already loving the split view nevertheless ;-)

Comment 7 Eric Moffatt

2014-02-13 15:01:29 EST

I'll start looking at this today...

Comment 8 Eric Moffatt

2014-02-14 15:12:59 EST

Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6bfc82c165a59bea8039c9aa7ce6af39efcf8b83

This fixes the delegation of the activation of an MCompositePart to its 'inner' part by moving it out of the SplitHost and making it an integral part of the 'activate' method.

There's still a smaller defect having to with the initial state after a re-start but we already have a defect to check this (bug 348954).

Comment 9 Eric Moffatt

2014-03-04 14:11:28 EST

Verified in 4.4.0.I20140303-2000.

Dani, I've only checked on the keybindings, not the menu items and such. If you see any other issues feel free to re-open or open a new defect for M7.

Comment 10 Dani Megert

2014-04-09 05:58:14 EDT

(In reply to Eric Moffatt from comment #9)
> Verified in 4.4.0.I20140303-2000.
> 
> Dani, I've only checked on the keybindings, not the menu items and such. If
> you see any other issues feel free to re-open or open a new defect for M7.

Works for me using I20140408-1645.