Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423712

Summary:	Use estraverse in content assist
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	curtis.windatt.public, mamacdon
Version:	5.0
Target Milestone:	5.0 M2
Hardware:	All
OS:	All
Whiteboard:

Description Michael Rennie

2013-12-10 10:24:31 EST

The JS content assist should be updated to use estraverse like we did for mark occurrences and the outliner.

Comment 1 Michael Rennie

2013-12-11 13:18:38 EST

Content assist also does its own parsing, which is a major performance loss since the manager is likely holding the AST it would need anyway.

Comment 2 Michael Rennie

2013-12-17 15:36:08 EST

I pushed some starting work re-org'ing + cleaning up to gerrit: https://git.eclipse.org/r/19918

Comment 3 Michael Rennie

2013-12-18 14:07:57 EST

(In reply to Michael Rennie from comment #2)
> I pushed some starting work re-org'ing + cleaning up to gerrit:
> https://git.eclipse.org/r/19918

The cleanup has been merged: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a06fed364882f1ef7addb255f4a28ed7b4cda232

Comment 4 Michael Rennie

2014-01-20 21:38:03 EST

I pushed some updates that removes exception control flow from contentAssist.js and replaces it with estraverse: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=562f59eb07ce15de19b5b93c0677810aba49e2a9

Comment 5 Michael Rennie

2014-04-17 11:47:16 EDT

I'm going to mark this fixed. There is one last location using the old visitor that I do not plan to convert to estraverse.