| Summary: | JSON constants should be bold | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Editor | Assignee: | Grant Gayed <grant_gayed> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | grant_gayed |
| Version: | 5.0 | ||
| Target Milestone: | 5.0 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
Does the following set of keywords for JSON seem right (wondering about undefined in particular)? The full set of JS keywords is in keywords.js. true, false, null, undefined undefined is not valid JSON (it's a Javascript-ism). Highlighting numbers might be interesting too, but I'm mainly interested in true, false and null. This fix (true, false, null) is included in commit http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bcd95ed2810b85d531c95807c6fef1b9b364b12c . Numbers have always been coloured in .json, unless you have a specific case that's not working? (In reply to Grant Gayed from comment #3) > Numbers have always been coloured in .json, unless you have a specific case > that's not working? Ah, yes, this is true -- I guess I need a better monitor. |
I opened a .json file > { "blah": true, > "fgsk": false, > "flob": null > } The values true/false/null are styled as plain text. I expected them to be recognized as keywords, like they are in a .JS file.