Bugzilla – Full Text Bug Listing
| Summary: | successful status text shown when patch fails to apply | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> | ||||
| Component: | Git | Assignee: | Eric Moffatt <emoffatt> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | Carolyn_MacLeod, emoffatt, grant_gayed, snorthov | ||||
| Version: | 5.0 | Keywords: | triaged | ||||
| Target Milestone: | 10.0 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/57432 https://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=3bd58d3f809433550d6d035e506d06a9a6e3d7b0 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Grant Gayed
Actually the problem is not what I thought, I now see that the patch was not successfully applied. I have not looked into whether this failure is legitimate or not, but the status message that was shown is misleading. Its problem is not the missing list of modified files, since in this case this set is in fact empty, but it should have been an error status message with words indicating the failure. The patch file I was trying to apply was not actually a patch file, so the failure is legitimate, just the resulting message that is not. Still happens in the latest, providing my id_dsa file as the patch file showed a "successfully applied" status. We can't be telling people that a patch file has applied when it has not, even if the file is garbage. Please fix this. This is at least partly fixed; the message no longer has a ':' in it and we can induce a valid failure message applying a corrupted patch. However, we also tried applying a regular txt file as a patch (attachment coming) and it gave a success message even though it couldn't have worked... Created attachment 257042 [details]
apply this file as a patch and it'll look like it succeeded...why?
This is a case where JGIT is actually incorrectly stating that the file correctly 'applied' as a patch (but if you look at the results then while there are no errors there are also no files...). I'm looking at detecting this in the server side handler for this, checking if any files have changes and indicating an 'Incorrect patch format' if no files have changed (sort of a philosophical question.."Can a patch that changes no files be correctly formatted?"). New Gerrit change created: https://git.eclipse.org/r/57432 Gerrit change https://git.eclipse.org/r/57432 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=3bd58d3f809433550d6d035e506d06a9a6e3d7b0 Thanks Silenio... If anybody wants to change the message go ahead, it's the best we could come up with... |