Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423562

Summary:

Cleanup and standardize project settings

Product:

[Modeling] Sirius

Reporter:

Pierre-Charles David <pierre-charles.david>

Component:

Core

Assignee:

Pierre-Charles David <pierre-charles.david>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

laurent.redor

Version:

0.9

Keywords:

triaged

Target Milestone:

1.0.0M5

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch to enable Checkstyle on projet table.ui	none

Description Pierre-Charles David

2013-12-09 04:37:30 EST

All the Sirius plug-in projects should use the same configuration settings in terms of:
* Java compiler settings
* Java Formatter and Cleanup
* PDE settings
* CheckStyle configuration

Right now there are several projects which do not follow the same rules as the rest, and the CheckStyle and formatter settings still live outside of Sirius.

Comment 1 Laurent Redor

2013-12-09 05:15:45 EST

Created attachment 238158 [details]
Patch to enable Checkstyle on projet table.ui

For information, there is a mistake in current configuration of org.eclipse.sirius.table.ui. Checkstyle is not enabled.

I attached a patch for the ".project" file of this project.

Comment 2 Pierre-Charles David

2013-12-24 05:41:15 EST

Done, even though things can certainly be improved (maybe later).

See commits 5c31823acaad44ac233bc3a82214c1614f75cd4b through aa2ee4007182d5dfcf39374edc8923551fe5cfbd.

Comment 3 Pierre-Charles David

2013-12-24 05:41:48 EST

See previous comment.

Comment 4 Laurent Redor

2014-01-07 10:05:33 EST

I think the checkstyle configuration is problematic. All config files reference a check-config-name="Sirius Checks". This implies to have configure a check-configuration in the workspace with that name.
It is possible to directly reference the existing file with a "local-check-config" tag. For example, in previous revision : 

...
<local-check-config name="Viewpoint" location="/Viewpoint/dev/code/CheckstyleConfiguration.xml" type="project" description="">	
   <additional-data name="protect-config-file" value="false"/>
</local-check-config>
<fileset ... enabled="true" check-config-name="Viewpoint" local="true">
...

Why do not you use this possibility?

Comment 5 Pierre-Charles David

2014-01-21 04:27:24 EST

(In reply to Laurent Redor from comment #4)
> I think the checkstyle configuration is problematic. All config files
> reference a check-config-name="Sirius Checks". This implies to have
> configure a check-configuration in the workspace with that name.
> It is possible to directly reference the existing file with a
> "local-check-config" tag. For example, in previous revision : 
> 
> ...
> <local-check-config name="Viewpoint"
> location="/Viewpoint/dev/code/CheckstyleConfiguration.xml" type="project"
> description="">	
>    <additional-data name="protect-config-file" value="false"/>
> </local-check-config>
> <fileset ... enabled="true" check-config-name="Viewpoint" local="true">
> ...
> 
> Why do not you use this possibility?

This was simply because even after reading the CheckStyle doc I was confused about what exactly were the different types of configurations.

Changed in 40aeb70d6b6f98511f6d16e1bfa6c74b4e64bfee.

Comment 6 Pierre-Charles David

2014-01-27 11:07:42 EST

Validated using:
* Luna M4
* Sirius 1.0M5rc1 (1.0.0-N20140127-060036)

Comment 7 Pierre-Charles David

2014-01-31 05:38:12 EST

Available in Sirius 1.0.0M5, see https://wiki.eclipse.org/Sirius/1.0.0M5 for availability details.