Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423386

Summary:	Sidebar resizing in a filtered outline mode causes 'View' menu button to disappear
Product:	[ECD] Orion	Reporter:	Elijah El-Haddad <elijahe>
Component:	Client	Assignee:	Elijah El-Haddad <elijahe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti, simon_kaegi
Version:	5.0	Flags:	Silenio_Quarti: review+
Target Milestone:	5.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Elijah El-Haddad

2013-12-05 17:32:31 EST

Shrinking the sidebar when viewing a source outline causes the 'View' menu button to jump down on the screen and become un-clickable eventually disappearing. Since the 'View' menu button is the only way to jump back to the Navigator it should take precedence over the filter input box and remain visible as long as possible.

I have a potential fix for this.

Comment 1 Elijah El-Haddad

2013-12-06 13:18:26 EST

Here's the proposed fix: https://github.com/elijahe/orion.client/commit/74f097022806cb8cc5189c9ba955bc6dc6f0650d

Please review and push if appropriate.

Comment 2 Elijah El-Haddad

2013-12-06 17:21:17 EST

Commit after Silenio's review: https://github.com/elijahe/orion.client/commit/a0b1df7a4f6a572b2fc8c8dfb6ae0cba9ed9534f

Comment 3 Silenio Quarti

2013-12-06 17:30:19 EST

Push to eclipse.org.

Comment 4 Elijah El-Haddad

2013-12-09 12:09:42 EST

Used CSS calc to make filter input as wide as possible: https://github.com/elijahe/orion.client/commit/9b15665c059c4645dc0e11d2aba199a1cbf292e1

Comment 5 Silenio Quarti

2013-12-09 12:15:59 EST

(In reply to Elijah El-Haddad from comment #4)
> Used CSS calc to make filter input as wide as possible:
> https://github.com/elijahe/orion.client/commit/
> 9b15665c059c4645dc0e11d2aba199a1cbf292e1

Pushed

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ca76608ca179a06fdde779f84cc696e2553dda9c

Comment 6 Elijah El-Haddad

2013-12-09 12:20:59 EST

Bug fixed