Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423186

Summary:	Need to "clean out" old or unsupported modules from git repositories
Product:	[Eclipse Project] Platform	Reporter:	David Williams <david_williams>
Component:	Releng	Assignee:	Platform-Releng-Inbox <platform-releng-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, Lars.Vogel, pwebster
Version:	4.4
Target Milestone:	4.4
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:	420471, 423840, 427219, 427221
Bug Blocks:	420779, 422762

Description David Williams

2013-12-04 10:10:29 EST

This is a continuation of bug 422415, which was about a specific case of "old stuff" in a repository, that was no longer used and clearly obsolete, and requested to be removed from master to reduce clutter and confusion and wasted time trying to "figure them out" when in fact there was no need to figure them out since they weren't built. 

But besides those obviously obsolete cases, many of our repositories have modules we currently don't build. In some cases, there are loose plans to maybe build them in the future and in some other cases, it's clear we will never "deliver"  as a built module, but there are still uses for them, by someone, for some cases. 

So the question arose how to both "reduce clutter", but at same time not lose the ability to have those "partially supported" modules to participate in refactoring, and not make them hard to find, or load into workspace, etc. 

One suggestion was to have in a separate folder. Another possibility might be to have them in a separate repository, that is a submodule of the original repository (which would make it a submodule of a submodule). 

Or, we could leave things as they are and just live to learn with the clutter. 

I'm not sure if there's a good answer, but didn't want to lose the general topic, since it applies to nearly all our repositories.

Comment 1 David Williams

2013-12-04 10:21:50 EST

(In reply to David Williams from comment #0)
> ... live to learn with the clutter

I of course meant "learn to live with the clutter" ... but I sort of like the concept of "living to learn" :)

Comment 2 David Williams

2013-12-06 13:59:27 EST

Another "large class" of projects which probably need some attention are "e4" bundles which are either obsolete, still incubating, or, perhaps a "tool only". 

For an example of "tool only", I'm thinking of 
org.eclipse.e4.ui.model.workbench.edit

since it "prereqs" emf.edit, which is not part of our "normal" prereqs, I always have to close it in my workspace ... though pretty sure its actively used to update the workbench model. 

Any better location for it? Such as put it in different repository and perhaps still have it be a submodule of eclipse.platform.ui so those that want it can get it easily, and those that don't want it can simply not clone that "sub-repository"? 

There's more than these few but some examples of "e4 samples/examples/incubating" components that I have closed due to some sort of error or other are 
org.eclipse.e4.demo.e4photo
org.eclipse.e4.demo.split.renderer.swt
org.eclipse.e4.ui.examples.css

Paul, any suggestions? Even if long term? 

Again, my main goal is to "lower barriers to entry" so people can "check out" our stuff with a minimum of fuss and compile errors. 

It'd be nice if we could solve via the magic of git, but otherwise I think we need some "documentation" on "what's what". 

Thanks for any ideas.

Comment 3 David Williams

2013-12-07 11:05:23 EST

Adding Lars, since he'd have at least interest in the "e4 tools" issues ... if not the whole topic.

Comment 4 Lars Vogel

2013-12-09 05:24:01 EST

> org.eclipse.e4.ui.examples.css

> Adding Lars, since he'd have at least interest in the "e4 tools" issues ... if > not the whole topic.

Thanks a lot, yes clean-up bugs are very interesting for me.

> org.eclipse.e4.ui.examples.css

org.eclipse.e4.ui.examples.css can be remove IMHO, it served as an initial test container for the CSS styling but is not actively maintained.

> org.eclipse.e4.demo.split.renderer.swt

Can be removed IMHO, was the first test implementation which is now handled by Eric Moffat in Bug 378298.

> org.eclipse.e4.demo.e4photo

I would vote for removing it, we have the contacts demo which I'm in the process of updating to the latest Eclipse 4.3 API and I think one demo is sufficient.

> Again, my main goal is to "lower barriers to entry" so people can "check
> out" our stuff with a minimum of fuss and compile errors. 

+1. I think deleting stuff from master will help on the long term to gain more contributions.

> It'd be nice if we could solve via the magic of git, but otherwise I think
> we need some "documentation" on "what's what". 

I need to look at "org.eclipse.e4.ui.model.workbench.edit", I haven't actively used it yet.

Comment 5 Paul Webster

2013-12-09 06:03:11 EST

(In reply to David Williams from comment #2)
> For an example of "tool only", I'm thinking of 
> org.eclipse.e4.ui.model.workbench.edit

I thought this was used while providing the e4 Tools editor (it's the generated edit bundle).  If not, it could be removed.  You have to have the EMF SDK (which I do :-)

> 
> There's more than these few but some examples of "e4
> samples/examples/incubating" components that I have closed due to some sort
> of error or other are 
> org.eclipse.e4.demo.e4photo

This is a valid demo, I wouldn't delete it.  It needs a nebula widget.

> org.eclipse.e4.demo.split.renderer.swt

Eric would know better for this one, but if it doesn't compile then it probably has been left behind.

> org.eclipse.e4.ui.examples.css

Bogdan would be able to tell us about this one.

PW

Comment 6 Lars Vogel

2014-01-23 16:05:07 EST

(In reply to Paul Webster from comment #5)
> > org.eclipse.e4.demo.split.renderer.swt

I deleted that a while ago after Eric implemented the standard split editor functionality.

> > org.eclipse.e4.ui.examples.css

Does not look useful to me, I think we can safely delete it.

https://git.eclipse.org/r/21013

Comment 7 Lars Vogel

2014-01-29 06:09:12 EST

(In reply to Lars Vogel from comment #6)
> > > org.eclipse.e4.ui.examples.css

Removed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8ba43c4b41d2fc415868a86e80e1df515a9c486a

Is their more David, or shall we mark this bug as fixed?

Comment 8 Lars Vogel

2014-03-25 05:24:40 EDT

David, I mark this one as fixed and suggest we open new bugs for other plug-ins we would like to remove. This bug gets hard to read and we solved a few of these items already.