Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423176

Summary: Make demos work outside of Equinox
Product: [RT] RAP Reporter: Ralf Sternberg <rsternberg>
Component: DemoAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: ivan, tbuschto
Version: 2.2   
Target Milestone: 2.2 RC2   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch: Replace dependency to core.runtime in demo bundles ivan: review+, tbuschto: review+

Description Ralf Sternberg CLA 2013-12-04 07:42:15 EST 
The following demo bundles have a Require-Bundle dependency on org.eclipse.core.runtime, which in turn depends on org.eclipse.osgi:
* org.eclipse.rap.demo.controls
* org.eclipse.rap.demo.databinding
* org.eclipse.rap.examples.pages

In order to make the controls and examples bundles work in other environments, we should replace this dependency with package imports or a dependency to org.eclipse.equinox.common. The demo.databinding bundle does not need core.runtime at all.
Comment 1 Ralf Sternberg CLA 2013-12-04 07:57:06 EST 
Created attachment 238003 [details]
Patch: Replace dependency to core.runtime in demo bundles

A package import of org.eclipse.core.runtime would be preferable but lead to obscure problems when testing with virgo nano (split packages?). Since the jface bundle also requires equinox.common, exchanging Require-Bundle: org.eclipse.core.runtime with Require-Bundle: org.eclipse.equinox.common should be safe and is at least an improvement.
Comment 2 Ivan Furnadjiev CLA 2013-12-04 08:19:39 EST 
Comment on attachment 238003 [details]
Patch: Replace dependency to core.runtime in demo bundles

Looks safe to be included in 2.2RC2.
Comment 3 Tim Buschtoens CLA 2013-12-04 08:31:14 EST 
Comment on attachment 238003 [details]
Patch: Replace dependency to core.runtime in demo bundles

I can't see anything wrong with the patch. +1
Comment 4 Ralf Sternberg CLA 2013-12-04 09:00:15 EST 
Applied the patch with commit 3165f1599a6d96f4f1811ae286cf56ee7a2e8a6e