Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 423052

Summary:	Move diagram-specific EPackages into their own diagram.ecore model
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Diagram	Assignee:	Laurent Redor <laurent.redor>
Status:	CLOSED FIXED	QA Contact:	Maxime Porhel <maxime.porhel>
Severity:	major
Priority:	P2	CC:	florian.barbin, laurent.redor, maxime.porhel
Version:	unspecified	Keywords:	triaged
Target Milestone:	1.0.0M6
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	423037
Bug Blocks:	427803

Description Pierre-Charles David

2013-12-03 11:07:02 EST

Once bug 423037 is done, the next step is to physically split the new diagram-specific packages into a new diagram.ecore. Doing this will involve breaking any cyclic dependencies between the concerned packages. In the end, viewpoint.ecore should not depend in any way on diagram.ecore.

The new ecore will be placed along with viewpoint.ecore, still in the org.eclipse.sirius bundle. Moving this into org.eclipse.sirius.diagram will be yet another separate task.

Comment 1 Pierre-Charles David

2013-12-03 11:09:18 EST

Planning for M4 to at least start the work, but it will probably land only in M5.

Comment 2 Pierre-Charles David

2014-01-21 04:36:48 EST

Moving to M6.

Comment 3 Laurent Redor

2014-01-30 07:47:01 EST

The first step is done: Bug 423037.
I now start the second step.

Comment 4 Laurent Redor

2014-02-10 10:20:00 EST

As the first step, this step was commited in several time to facilitate the review:
* Move diagram-specific EPackages into their own model [1]
* Generate model code [2]
* Generate edit code [3]
* Generate editor code [4]
* Generate model, edit and editor code for sequence diagram. [5]
* Fix compilation problems caused by this move. [6]
* Adapt migration [7], [8]
* Fix regressions [9], [10], [11]
* Complete release notes [12]

Now, go the the final step ...

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=58c788056282b7eb0c7a3a2e91a479c894d7f9da
[2] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0e5e2bdb7dc61d76b9091f34d095b7c48b6f2e8f
[3] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8a326f8047e7da17c9a90e77bb6f64564882fc34
[4] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2ac507af28192265e06ff02e1f703661107572a4
[5] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2907302b2f7fa0cb471205ee24287cf6e8dbc08e
[6] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1ea9423d6497979d2076716c37551d75307d1bf4
[7] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f2bc24d7ba76234d114f9fbe90199032cd10c316
[8] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=09f32482aa24937d71645ae53c3de541c74f58b9
[9] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fcd88555a0db42e5e9fca0b7e662891fec89a0a7
[10] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2620d225aa20066ea626c5b0f23ef15457370511
[11] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d698265ca8226eb903853fa8dec9701aac4cca00
[12] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ebfcfe0acea5b1f726c4ec8974dd20bc160f1311

Comment 5 Maxime Porhel

2014-03-07 05:55:52 EST

Verified on 1.0.0-N20140306-1638 nightly build.

Diagram dialect continues to work, this change does not break our internal automated tests.

Comment 6 Pierre-Charles David

2014-03-17 10:07:13 EDT

Available in Sirius 1.0.0M6 (see https://wiki.eclipse.org/Sirius/1.0.0M6).