Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 422974

Summary:

[Text] Multi-Line Text with border-radius not focusable by mouse in IE9

Product:

[RT] RAP

Reporter:

Tim Buschtoens <tbuschto>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

rsternberg, tbuschto

Version:

2.2

Target Milestone:

2.2 RC2

Hardware:

All

OS:

All

Whiteboard:

sr212

Attachments:

Description	Flags
patch for 2.2	tbuschto: review?, rsternberg: review+

Description Tim Buschtoens

2013-12-02 11:09:47 EST

An Internet Explorer 9 (or a IE11 in IE9 mode) does not propperly focus a multiline text field with rounded borders if the mouse clicks on a blank space. So if there is no text at all in the field, the element can only be focused by keyboard.

Comment 1 Tim Buschtoens

2013-12-02 11:32:51 EST

Created attachment 237921 [details]
patch for 2.2

Fixes the issue by setting blank.gif as the background image of the textearea element. Important notice: I currently don't have a "real" IE9 to test this on, only emulated by IE11. This means two things:
1) I don't know for sure this issue appears in a non-emulated IE9
2) I can't run the complete js test suite since there is a bug in IE9 that is not emulated by IE11, which causes a red test (ScrolledCompositeTest#testScrollOutOfBounds).

Comment 2 Tim Buschtoens

2013-12-02 11:38:21 EST

There is an easy workaround: Set border-radius for MULTI Text to 0, which is the default anyway, except in the old business theme. Therefore this isn't a must-have for 2.2RC2, but if we do it and port it to 2.1.2 too, all 2.x versions would propperly support IE9 (except 2.0, which is really close to 2.1 anyway).

Comment 3 Ivan Furnadjiev

2013-12-03 02:38:09 EST

(In reply to comment #1)
> Created attachment 237921 [details]
> patch for 2.2
The fix looks safe for me. +1 to include it in 2.2RC2.

Comment 4 Ralf Sternberg

2013-12-03 05:35:55 EST

Comment on attachment 237921 [details]
patch for 2.2

I agree that the risk is minimal and we should include this patch in 2.2 and also backport it to 2.1.2

Comment 5 Ivan Furnadjiev

2013-12-03 07:49:44 EST

(In reply to comment #4)
> Comment on attachment 237921 [details]
> patch for 2.2
> 
> I agree that the risk is minimal and we should include this patch in 2.2
Applied the patch to master with commit 9cac3a9f57a3bab3ed24c46bf64d3760ce4b49ae.

Comment 6 Ralf Sternberg

2014-01-27 07:39:34 EST

Can we be sure that we do not introduce a regression for text fields that have a background image set or should render a transparent background because of parent.backgroundMode == SWT.INHERIT_FORCE?

Comment 7 Tim Buschtoens

2014-01-27 09:46:25 EST

The blank.gif is applied to the input element, the theming background to the parent div. The only way this could cause issues is if IE manages to screw up the rendering of the blank.gif. This isn't totally unheared of (Bug 303603), but this was for PNGs and older IEs.

So no, we can't be totally sure that this won't cause regressions, but I would vote to backport it anyway.

Comment 8 Ralf Sternberg

2014-01-27 11:04:51 EST

That's fine with me. Maybe it's worth doing another check with saucelabs for this case after backporting.

Comment 9 Ivan Furnadjiev

2014-01-31 07:01:42 EST

Backported to 2.1-maintenance branch with change https://git.eclipse.org/r/21372