Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 422848

Summary:

Allow users to vote and submit feedback on new logo

Product:

Community

Reporter:

Christopher Guindon <chris.guindon>

Component:

Website

Assignee:

phoenix.ui <phoenix.ui-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

denis.roy

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Mac OS X

Whiteboard:

Attachments:

Description	Flags
Patch #1	none
Screenshot of the expected final result	none
Patch #2: Modal window needed to be bigger for FF	none

Description Christopher Guindon

2013-11-29 09:30:19 EST

I created a patch that will allow users to submit feedback on logo concept that we are considering.

The survey is done with servey monkey and this new functionnality will included on all nova pages.

How it works:

If the users clicks on the logo, a modal that includes the survey will be presented to the user.

I am using CSS MODAL for this functionality:
http://drublic.github.io/css-modal/

I decided to use CSS modal because: 

1. No dependencies with jQuery. This is important because I cannot use $App in promotions.php. I also think it would be overkill to load jQuery on all of pages for this new functionality.

2. Lightweight

3. License: https://github.com/drublic/css-modal/blob/master/LICENSE.md

I am using inline css because I cannot use $App in promotions.php to add a css file in <head>. I also don't want to submit a patch to 2 different repo (eclipse.org-common.git) for this because we will want to remove this functionality once we are done with the voting.

This was designed so that it's going to be easy to remove once we are done.

Denis, could you review this code today? Ian would like to start using this on Monday.

Comment 1 Christopher Guindon

2013-11-29 09:33:57 EST

Created attachment 237852 [details]
Patch #1

Submitting patch for this functionality.

Comment 2 Christopher Guindon

2013-11-29 09:36:13 EST

Created attachment 237854 [details]
Screenshot of the expected final result

Comment 3 Christopher Guindon

2013-11-29 09:52:24 EST

If you are curious about the image that is embed in the css with a base64 string, you can use this tool to decode it:

http://www.motobit.com/util/base64-decoder-encoder.asp

Export to a bin file and rename it to a png.

Comment 4 Christopher Guindon

2013-11-29 10:12:27 EST

Created attachment 237859 [details]
Patch #2: Modal window needed to be bigger for FF

Comment 5 Denis Roy

2013-11-29 10:20:53 EST

Looks good to me, but isn't your patch missing "logovoting/promotion-newlogo.php" ?

Comment 6 Christopher Guindon

2013-11-29 10:43:44 EST

(In reply to Denis Roy from comment #5)
> Looks good to me, but isn't your patch missing
> "logovoting/promotion-newlogo.php" ?

No it's there:

(-)a/promotions/logovoting/promotion-newlogo.php (+315 lines)

Comment 7 Denis Roy

2013-11-29 10:46:26 EST

Ah, I see it.  I was confused by all the CSS.

iframe eh?  Aren't those the root of all evil?

Comment 8 Christopher Guindon

2013-11-29 10:58:55 EST

(In reply to Denis Roy from comment #7)
> Ah, I see it.  I was confused by all the CSS.
> 
> iframe eh?  Aren't those the root of all evil?

They are if we allow users to embed an iframe on our website. As soon as you're displaying content from another domain, you're basically trusting that domain not to serve-up malware.

FWIW, eclipse.org homepage, our downloads page, eclipsecon.org are all using iframes for the facebook and the twitter widget.

Comment 9 Christopher Guindon

2013-12-05 14:08:17 EST

I sent this to gerrit for review. I wanted to test out the gerrit workflow and make the review official at the same time!

https://git.eclipse.org/r/#/c/19392/

Comment 10 Christopher Guindon

2014-02-10 16:53:03 EST

We are done here.

Closing this bug.