Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 422759

Summary:	[eslint] Missing 'unused variables' warning
Product:	[ECD] Orion	Reporter:	Maciej Bendkowski <maciej.bendkowski>
Component:	JS Tools	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon.bugs, mamacdon
Version:	unspecified
Target Milestone:	5.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Maciej Bendkowski

2013-11-28 08:03:56 EST

Since we've changed our JS validator, functions with unused variables are no longer triggering an 'Unused variables' warning.

Comment 1 Mark Macdonald

2013-11-28 12:30:48 EST

Need to implement the 'no-unused-vars' rule.

Comment 2 Mark Macdonald

2013-12-11 14:25:46 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fa07276

Fixed. The following warnings are now shown:

a) If a function or var named 'x' is declared but never referenced:
> 'x' is never used.
b) If a function or var named 'x' is written to, but never read:
> 'x' is never read.

As always, please open bugs if this differs from your expectations.