Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 422699

Summary: PDE build should reuse minification script orion.mini.xml from Maven/Tycho build
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: RelengAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 5.0   
Target Milestone: 6.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 422476    
Bug Blocks:    

Description Mark Macdonald CLA 2013-11-27 13:52:32 EST
The PDE build's customTargets.xml script contains calls to r.js for every Orion page that gets minified:

>  <optimize pageDir="." name="index" bundle="org.eclipse.orion.client.ui" />
>  <optimize pageDir="edit" name="edit" bundle="org.eclipse.orion.client.ui" />
>  ...

These same calls are present in orion.mini.xml (which is used by the Tycho build).

customTargets should reuse orion.mini.xml rather than duplicate it.
Comment 1 Mark Macdonald CLA 2014-03-07 11:33:01 EST
This was fixed by bug 429077, mostly by this commit

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=bd6aee6