Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 422645

Summary:

rowTemplate Right tracking and refresh issue - rows not redraw on table resize

Product:

[RT] RAP

Reporter:

John Gymer <jgymer>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ivan, rsternberg, tbuschto

Version:

2.2

Target Milestone:

2.2 RC1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch	ivan: review+, rsternberg: review+

Description John Gymer

2013-11-27 04:33:38 EST

With Right+Width sizing for a cellImage/cellText, when the containing Table resizes, the cells are not redrawn until hovered over with the mouse.

Please refer to Forum thread for screen shot:
http://www.eclipse.org/forums/index.php?t=msg&th=621017&

Comment 1 Tim Buschtoens

2013-11-27 04:59:12 EST

Created attachment 237747 [details]
Proposed patch

Pathc for consideration for 2.2RC2.

Notes:
All this does is re-render all rows if the grid is horizontally resized. This wasn't necessary before since the rows were only depending on the size of the columns, not the grid. I decided against checking for a row template and always re-rendering the rows instead, as this isn't a performance-critical point in time. It always happens (at maximum) once during a server response, which take a while anyway and aren't happen very often compared to scroll events for example.

Also, I did not include the rebuild client.js in the patch for obvious reasons, but of course we shouldn't forget it when pushing the changes.

Comment 2 Ivan Furnadjiev

2013-11-27 05:21:31 EST

Comment on attachment 237747 [details]
Proposed patch

The fix looks good to me. +1

Comment 3 Ralf Sternberg

2013-11-27 05:23:48 EST

Comment on attachment 237747 [details]
Proposed patch

The patch looks good to me too

Comment 4 Tim Buschtoens

2013-11-27 05:38:48 EST

Applied patch with commit c60502a30506ac9ef5c0dccbfcb4d1f053c33b2b.