Bugzilla – Full Text Bug Listing
| Summary: | Plugin key bindings should be specific to content type | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Jon Johnson <jonjonsonjr> | ||||
| Component: | Client | Assignee: | Project Inbox <orion.client-inbox> | ||||
| Status: | RESOLVED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | lmsurpre, Silenio_Quarti | ||||
| Version: | 4.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Jon Johnson
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=422624 for why this is necessary. I have multiple plugins to reformat text, and I'd like them all to share the same key binding but operate on different content types. *** This bug has been marked as a duplicate of bug 422563 *** Please try the latest code. This was fixed yesterday. Silenio, I installed Jon's plugin from https://github.com/jonjonsonjr/beautify, tried it with a fresh clone of org.eclipse.orion.client, and I noticed that all three format options now show up in the bindings list (see attachment). Is that expected? Shouldn't it be restricted to just the bindings that are valid for the currently open content type? Is he doing something wrong when he registers them? Should we reopen this bug? I also noticed that, on this fresh checkout from master, this keybinding (Alt + F) doesn't work for me on my Mac any more. This is also true for the 'original' jsbeautify from https://orion-plugins.googlecode.com/git/0.5/plugins/beautify/jsbeautify.html. Instead, it just adds a 'ƒ' character. Is this part of the code in flux? Should I open a separate bug for it? Created attachment 239404 [details]
All three formatting shortcuts show up instead of just the html one
Note that only the proper button is shown, but all three shortcuts are still listed. Clicking on the Format HTML option does work as expected.
Bug#422563 was about the fact that all the key bindings were active independent of the content type of the opened resource. The key assist panel has always shown all the registered key bindings (not only the ones active to the moment). I reopened the bug to investigate whether this was done by accident or it was the indented behavior. All can see people that would like to see all the key bindings registered. The fact that Alt+F does not work on the Mac is not a bug. That key combination generates a character (most keys with the alt modifier do on Mac) and it should not be used as a shortcut on editors. Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |