Bugzilla – Full Text Bug Listing
| Summary: | [Commands] Group menus "blink" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Malgorzata Janczarska <malgorzata.tomczyk> | ||||
| Component: | Client | Assignee: | Project Inbox <orion.client-inbox> | ||||
| Status: | RESOLVED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | maciej.bendkowski, Silenio_Quarti | ||||
| Version: | 5.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Possible duplicate: bug 418884. Created attachment 237864 [details]
possible fix
This fixes the blinking of the "More" button.
Gosia, do you see the problem you described after making your change with this patch? Is there a case that shows that issue in Orion?
I bumped on this problem while implementing stuff for deploy story, so it's not yet in the code, but as Maciek pointed bug 418884 that is probably another example (your patch fixes it). As for your patch, this is exactly what I meant in here: > But when we render the menuButton with style.visibility = "hidden" we can also see the blinking, but the other way around: when the group should be visible it disappears for a moment. If you apply your patch and then go to navigator, select something and then keep pressing up or down arrow (changing selection fast) you will see the gear and plus blinking. This is the conflict here: adding and removing the line you proposed makes either visible or invisible group icon to blink. Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |
Currently when we call renderCommands on a scope that contains a group menu, but all the actions in the group have visibleWhen==false the group menu shows for a short moment and then disappears. This is especially visible when the actions renderer on selection, because the menu blinks on every selection change. I can see that in commands registry we must have something to prevent this, because there is still > created.menuButton.style.visibility = "visible" line present. But when we render the menuButton with style.visibility = "hidden" we can also see the blinking, but the other way around: when the group should be visible it disappears for a moment.