Bugzilla – Full Text Bug Listing
| Summary: | help feature "extra requirement" for Lucene, in POM, can be removed | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Williams <david_williams> |
| Component: | Releng | Assignee: | David Williams <david_williams> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 4.2.2 | ||
| Target Milestone: | 4.4 M4 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=bdd464903d46a392a7813dd4d603d55b4178dac9 in my test build, there was same number of jar files in SDK and (more important) the "repository" as there was in the last I build I20131119-0800. In fact, the I build repo had (only) org.apache.lucene.analysis_3.5.0.v20120725-1805.jar and org.apache.lucene.core_3.5.0.v20120725-1805.jar (Not the umbrella lucene bundle) So, I think this is a relatively safe change (though, I suppose, some other lucene bundle could "embedded" inside another jar/war file? (In reply to David Williams from comment #1) > http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/ > ?id=bdd464903d46a392a7813dd4d603d55b4178dac9 > Made a "typo" in above fix, and corrected it in http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=6ef9aed6e407558c6df23de4463ff785058abdc7 Just realized since this is a "pom only" change, it would be best to "touch" the feature to make sure "most recent one" is being used in final distribution. Its not expected this would make any difference in feature contents, I think this is safer approach ... just in case something is "hidden". So, I've "touched" forceQualifierUpdate.txt, and will do a local test I-build to make sure no surprises. From what I can tell, the service field has already been incremented over R4_3_maintenance, so do not believe that is required. |
The pom for org.eclipse.help-feature specifies "extra requiremnt" for lucene: <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>target-platform-configuration</artifactId> <configuration> <dependency-resolution> <extraRequirements> <requirement> <type>eclipse-plugin</type> <id>org.apache.lucene</id> <versionRange>[3.5,4.0)</versionRange> </requirement> <requirement> <type>eclipse-plugin</type> <id>org.apache.lucene.analysis</id> <versionRange>[3.5,4.0)</versionRange> </requirement> </extraRequirements> </dependency-resolution> </configuration> </plugin> I was first looking at this because I thought 'org.apache.lucene' should be changed to 'org.apache.lucene.core' but upon more thought, I think the whole section can now be removed. I suspect this could have been removed earlier, once we moved to lucene "3.5" instead of "2.9" but now especially since bug 400518 has been fixed, we should no longer need it. I'll do a test build to make sure there are no surprises, and if not check into main repository (in master, only).