| Summary: | Update git repository explorer look and feel for consistency and clarity | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Curtis Windatt <curtis.windatt.public> |
| Component: | Git | Assignee: | Curtis Windatt <curtis.windatt.public> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | antonm, mamacdon, Michael_Rennie, Szymon.Brandys |
| Version: | 5.0 | ||
| Target Milestone: | 5.0 M1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Curtis Windatt
https://git.eclipse.org/r/18698 Changes the html structure to be like the other section tables on the status and repo detail pages. I overwrite the css top margin for the sectionWrapper div. 30px ends up spreading the repositories in the list a little far apart, so 15px is more reasonable. Reducing it to 15px also reduces the whitespace at the top of the page, which seemed more effective use of the space (considering the repo list previously left very little whitespace), but I can look at matching other pages for consistency. This looks good to me. I looked at Gerrit and I see Mark's +1 everything, but the change was not merged to master. Anyway the change looks nice. One minor comment is that the section header height is different between Repository and Repositories pages. Also I think that the first section with the repo name could be somehow highlighted, maybe we should use bigger fonts or something. I hope Anton will come up with ideas at some point. (In reply to Szymon Brandys from comment #3) > I looked at Gerrit and I see Mark's +1 everything, but the change was not > merged to master. I will merge it ASAP, we're just waiting on a prerequisite change in Gerrit that needs a small edit. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a0e61606c0f848669896cf497be9578106446620 This was merged with master. |