Bugzilla – Full Text Bug Listing
| Summary: | [Model] Add org.eclipse.e4.emf.xpath to a feature | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Williams <david_williams> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, emoffatt, Lars.Vogel, tom.schindl |
| Version: | 4.4 | Flags: | daniel_megert:
pmc_approved+
|
| Target Milestone: | 4.5 M7 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/43747 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=32c81d50cd97d14dc21e0c691c4f5e4fc2bba00c |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 437958, 442821 | ||
|
Description
David Williams
Yes, I need these, they're part of the work I'm doing for Luna. PW Ok, I'll change title and assume you won't forget to file a cq for org.apache.commons.jxpath (if you haven't already). Feel free to "dup" this against the larger effort if there's already a bug that covers this. *** Bug 462000 has been marked as a duplicate of this bug. *** (In reply to David Williams from comment #2) > Ok, I'll change title and assume you won't forget to file a cq for > org.apache.commons.jxpath > (if you haven't already). We consume org.apache.commons.jxpath already in our build so I assume we must have a CQ for it already. What is the work to be done here? Just add it to our SDK feature? If possible we would like to fix Bug 437958 in M6. (In reply to Lars Vogel from comment #4) > (In reply to David Williams from comment #2) > > Ok, I'll change title and assume you won't forget to file a cq for > > org.apache.commons.jxpath > > (if you haven't already). > > We consume org.apache.commons.jxpath already in our build so I assume we > must have a CQ for it already. Wow, are you trusting! :) > What is the work to be done here? Just add it to our SDK feature? If > possible we would like to fix Bug 437958 in M6. I would have assumed it'd be in some "lower" feature, such as e4.rcp ... is that not possible? But, yes, add to a feature at appropriate level. (In reply to David Williams from comment #5) > Wow, are you trusting! :) And I also have no idea how to check for an existing CQ. ;-) But if it is in Orbit... > > What is the work to be done here? Just add it to our SDK feature? If > > possible we would like to fix Bug 437958 in M6. > > I would have assumed it'd be in some "lower" feature, such as e4.rcp ... is > that not possible? > > But, yes, add to a feature at appropriate level. New Gerrit change created: https://git.eclipse.org/r/43747 David, this fails because it can not generate a source feature for jxpath. Do you know how I can solve that? Do we put external bundles somewhere else? (In reply to Lars Vogel from comment #8) > David, this fails because it can not generate a source feature for jxpath. > Do you know how I can solve that? Do we put external bundles somewhere else? Not sure. I think Tycho (still) does not pull in '.source' bundles for bundles it did not build. And have to be specified "manually" in a literal .source feature. And not sure where the "lowest" one is .. rcp? platform? Or, might have to specify the source bundle in the sdk feature. (You can probably tell from other example?) At the org.eclipse.e4.rcp feature level, you may need to add org.apache.commons.jxpath to the "excludes" list in the pom.xml. I did add org.apache.commons.jxpath.source to the .target file, so if/when you want to add it to sdk (or where ever) then it'd be ready. (In reply to Lars Vogel from comment #6) > (In reply to David Williams from comment #5) > > Wow, are you trusting! :) > > And I also have no idea how to check for an existing CQ. ;-) But if it is in > Orbit... Well, as project lead, you need to learn this stuff ... and how to look in CQ database :) Being in Orbit, means there is an Orbit CQ. And what ever project contributed it there must have a CQ for it. But, then any other project that uses is, must have their own CQ, to say they are "reusing Orbit" bundle. (So, "the Platform" needs one.) Perhaps the Platform already does ... but I think I mentioned it because it seemed like it might not have ... being a little side project, done in incubator first?) (In reply to David Williams from comment #10) > Well, as project lead, you need to learn this stuff ... and how to look in > CQ database :) But this sounds like a very, very boring task, so I hope by not knowing it, I can trick others to do this for me. ;-) Just kidding, do you know if there is documentation about this? (In reply to Lars Vogel from comment #11) > (In reply to David Williams from comment #10) > > Well, as project lead, you need to learn this stuff ... and how to look in > > CQ database :) > > But this sounds like a very, very boring task, so I hope by not knowing it, > I can trick others to do this for me. ;-) Just kidding, do you know if there > is documentation about this? No, not right off. I'd just start by clicking on the CQ in orbit, and trying to do some searches from there. (And that database is not as easy to search, as bugzilla, for some reason, even tough it it basically bugzilla). BTW, in some cases, if "third part jars" are add/changed, then the features involved (and maybe features that include those features) have to be "touched". I guess the "first time" done, you are literally changing the feature, so that should be ok, but later, for example, if we just increase the version in the target, then the feature has to be "touched". That is, has to be for I-builds. N-builds would still work. (In reply to David Williams from comment #10) > Being in Orbit, means there is an Orbit CQ. And what ever project > contributed it there must have a CQ for it. But, then any other project that > uses is, must have their own CQ, to say they are "reusing Orbit" bundle. > (So, "the Platform" needs one.) https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9385 (In reply to Lars Vogel from comment #13) > (In reply to David Williams from comment #10) > > Being in Orbit, means there is an Orbit CQ. And what ever project > > contributed it there must have a CQ for it. But, then any other project that > > uses is, must have their own CQ, to say they are "reusing Orbit" bundle. > > (So, "the Platform" needs one.) > > https://dev.eclipse.org/ipzilla/show_bug.cgi?id=9385 CQ approval given. Gerrit change https://git.eclipse.org/r/43747 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=32c81d50cd97d14dc21e0c691c4f5e4fc2bba00c Merged, I hope this does not break the build. I've added this to the post-API freeze exclude list. |