Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 421877

Summary:	[client] Spaces not removed from outliner IDs
Product:	[ECD] Orion	Reporter:	Elijah El-Haddad <elijahe>
Component:	Client	Assignee:	Elijah El-Haddad <elijahe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	simon_kaegi
Version:	5.0	Flags:	simon_kaegi: review+
Target Milestone:	5.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	394861

Description Elijah El-Haddad

2013-11-15 16:54:16 EST

The ouliner.js file attempts to remove illegal characters from labels before creating a DOM id for each row. It is however missing the removal of spaces. Spaces are explicitly pointed out as illegal characters in an id attribute. See:
http://stackoverflow.com/questions/70579/what-are-valid-values-for-the-id-attribute-in-html
http://www.w3schools.com/tags/att_global_id.asp

I have a fix for this and will be posting it shortly.

Comment 1 Elijah El-Haddad

2013-11-15 16:57:06 EST

Here's the proposed fix:

https://github.com/elijahe/orion.client/commit/fb9700380b298a7cbdb4f496d8086043f139e3aa

Please review and commit if appropriate.

Comment 2 Elijah El-Haddad

2013-11-15 17:27:30 EST

Also, can someone with appropriate permissions please assign this bug to me?

Comment 3 Elijah El-Haddad

2013-11-19 15:45:59 EST

Here's the same proposed fix committed into a separate branch: https://github.com/elijahe/orion.client/commit/b94bb2cd2f74b7639f6457fc389b62c532d5c2c3

Comment 4 Simon Kaegi

2013-11-19 18:01:34 EST

Thanks. Pushed to Master.