Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420914

Summary:	[server] Fix build.properties warnings
Product:	[ECD] Orion	Reporter:	Anthony Hunter <ahunter.eclipse>
Component:	Server	Assignee:	Anthony Hunter <ahunter.eclipse>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon
Version:	5.0
Target Milestone:	5.0 M1
Hardware:	PC
OS:	Linux
Whiteboard:

Description Anthony Hunter

2013-11-01 16:27:23 EDT

There are a bunch of build warnings in the Orion server development environment that are hiding real warnings that need to be fixed.

We need to fix the build.properties files so that we do not see these warnings:

'META-INF' should not be added to src.includes list as it is not required in source build.
'plugin.xml' should not be added to src.includes list as it is not required in source build.
Source folders should not be added to the src.includes list because they are included by default in source builds.
The 'javacProjectSettings' build entry should be set when there are project specific compiler settings
The file "plugin.xml" does not exist in the workspace
There is no 'jre.compilation.profile' build entry and the project has Java compliance preferences set
etc.

Comment 1 Anthony Hunter

2013-11-01 16:38:02 EDT

Fixed 22 warnings as well as fixing missing copyright notices with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=1a588117fa96ac00a597475bf853cb9b7735f393

Comment 2 Anthony Hunter

2013-11-01 16:45:02 EDT

Also fixed an empty plugin.xml warning with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=5fda6d15201cbd881ca7591b100b9659e495d309

Comment 3 Mark Macdonald

2013-11-05 10:39:20 EST

Despite the nag messages from PDE, making the builds use project-specific compiler settings has been somewhat problematic, because apparently lots of our project settings are incorrect.

[1] For example, the tests project failed to compile because it had set the severity of "Unused java import" to Error -- which never surfaces in Eclipse for some reason.

[2] The NPM bundle also failed to compile because its project-specific JDT compliance level was incorrectly set to Java 1.5 when it needs 1.6 API.

[2] http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=5b994f9
[1] http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=5680e9c

Comment 4 Anthony Hunter

2013-11-08 14:30:26 EST

Pushed commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=a2d319200fe260e685b96b199ac5a039a52802de
Which fixed the 2777 warnings in the tests bundle.

Comment 5 Anthony Hunter

2013-11-08 14:38:38 EST

Removed the -javacProjectSettings = true from the tests bundle that was added earlier in commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=66daf6ed8df4632de09107aaeea7a0600af18a7a

Also removed the specific version identifiers from one of the feature.xml, they are not needed and we can use the recommended 0.0.0, there is only one version of the bundle in orbit. Fixed with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=908e8dfeb5c75051676af2342e26071660b658c0