| Summary: | Unwanted items in the Customize functionality on the Intro page of Eclipse RCP | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | ALOK MANJREKAR <alokmanjrekar> | ||||
| Component: | User Assistance | Assignee: | Cornel Izbasa <cizbasa> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | cizbasa, daniel_megert, david_williams | ||||
| Version: | 4.2.2 | Keywords: | helpwanted | ||||
| Target Milestone: | 4.5 M1 | Flags: | daniel_megert:
review+
|
||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
(In reply to ALOK MANJREKAR from comment #0) > There should be an easy way to remove these items from showing up in the > "Customize" action of the Intro page, if the product configuration is not > including it. Perhaps. But suspect to simply disable them would be more consistent with UI Guidelines? I'm wondering would it be easy/possible for you to attach your configuration file? I'm asking for purely selfish reasons ... I'm just learning about this, so will help me understand better, and I can see if/how is behaves in current versions. (4.4 milestones). Also, I'm not a UI committer so not for me to say ... but, sounds like this would be a good "helpwanted" item. Submitted a patch for this via Gerrit: https://git.eclipse.org/r/#/c/20183/ (In reply to Cornel Izbasa from comment #2) > Submitted a patch for this via Gerrit: https://git.eclipse.org/r/#/c/20183/ Works but needs very minor tweaking. Hi Cornel Any plans to update your contribution? (In reply to Cornel Izbasa from comment #2) > Submitted a patch for this via Gerrit: https://git.eclipse.org/r/#/c/20183/ We have 2 community contribution days coming up and we'd like to get your patch in. Could you please update it to reflect Dani's comments in the Gerrit review? PW Cornel, any plans to provide an updated patch? It really only needs some minor changes. Our last set of community contribution days for Luna is coming up. Can you tweak your contribution? PW Really sorry, I completely forgot about this commit. Is there anything I can do about it now? Cornel (In reply to Cornel Izbasa from comment #8) > Really sorry, I completely forgot about this commit. > Is there anything I can do about it now? > > Cornel np. Just upload a new change so that we can consider it for 4.5. Submitted update after review: https://git.eclipse.org/r/#/c/27641/ Thanks, Cornel (In reply to Cornel Izbasa from comment #10) > Submitted update after review: https://git.eclipse.org/r/#/c/27641/ > > Thanks, > Cornel Hi Cornel. Can you please upload this to the original Gerrit change, so that we can easily compare the patch sets? Simply use the same change id (I455d6ed55d906913bff27810303242a0a3df65e2) when committing the change and pushing to Gerrit. (In reply to Cornel Izbasa from comment #10) > Submitted update after review: https://git.eclipse.org/r/#/c/27641/ Hi Cornel, could you update the patch? We can get this in early in Mars. PW I had already done it here (didn't post about it though): https://git.eclipse.org/r/#/c/20183/ Cheers, Cornel Thanks Cornel. Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=8e2e1d40c93ecd97446c1def3ac1f4ea4c09cb2a Thanks Dani and Lars! |
Created attachment 237121 [details] Screenshot The customize action on the Intro page of an Eclipse RCP brings up a dialog that allows the user to select a bunch of "Root Pages". There are a bunch of items which are not included in my product configuration. Ex - Samples, Migrate. Please see the attached screenshot to get an idea of what I mean. When the user checks these options, then there are links created for these items on the intro page. Clicking on them just opens up a blank page with no content. (since my product does not need them). Looks like these hard-coded in eclipse's internal intro ui plugin? There should be an easy way to remove these items from showing up in the "Customize" action of the Intro page, if the product configuration is not including it.