Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420843

Summary: Unwanted items in the Customize functionality on the Intro page of Eclipse RCP
Product: [Eclipse Project] Platform Reporter: ALOK MANJREKAR <alokmanjrekar>
Component: User AssistanceAssignee: Cornel Izbasa <cizbasa>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cizbasa, daniel_megert, david_williams
Version: 4.2.2Keywords: helpwanted
Target Milestone: 4.5 M1Flags: daniel_megert: review+
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Screenshot none

Description ALOK MANJREKAR CLA 2013-10-31 18:35:19 EDT
Created attachment 237121 [details]
Screenshot

The customize action on the Intro page of an Eclipse RCP brings up a dialog that allows the user to select a bunch of "Root Pages". 
There are a bunch of items which are not included in my product configuration.
Ex - Samples, Migrate. 
Please see the attached screenshot to get an idea of what I mean.

When the user checks these options, then there are links created for these items on the intro page. Clicking on them just opens up a blank page with no content. (since my product does not need them).

Looks like these hard-coded in eclipse's internal intro ui plugin?
There should be an easy way to remove these items from showing up in the "Customize" action of the Intro page, if the product configuration is not including it.
Comment 1 David Williams CLA 2013-10-31 20:16:34 EDT
(In reply to ALOK MANJREKAR from comment #0)

> There should be an easy way to remove these items from showing up in the
> "Customize" action of the Intro page, if the product configuration is not
> including it.

Perhaps. But suspect to simply disable them would be more consistent with UI Guidelines?

I'm wondering would it be easy/possible for you to attach your configuration file? I'm asking for purely selfish reasons ... I'm just learning about this, so will help me understand better, and I can see if/how is behaves in current versions. (4.4 milestones). 

Also, I'm not a UI committer so not for me to say ... but, sounds like this would be a good "helpwanted" item.
Comment 2 Cornel Izbasa CLA 2013-12-29 00:58:19 EST
Submitted a patch for this via Gerrit: https://git.eclipse.org/r/#/c/20183/
Comment 3 Dani Megert CLA 2014-01-08 08:51:20 EST
(In reply to Cornel Izbasa from comment #2)
> Submitted a patch for this via Gerrit: https://git.eclipse.org/r/#/c/20183/

Works but needs very minor tweaking.
Comment 4 Dani Megert CLA 2014-01-22 11:41:41 EST
Hi Cornel

Any plans to update your contribution?
Comment 5 Paul Webster CLA 2014-01-24 09:39:08 EST
(In reply to Cornel Izbasa from comment #2)
> Submitted a patch for this via Gerrit: https://git.eclipse.org/r/#/c/20183/

We have 2 community contribution days coming up and we'd like to get your patch in.  Could you please update it to reflect Dani's comments in the Gerrit review?

PW
Comment 6 Dani Megert CLA 2014-02-25 04:14:39 EST
Cornel, any plans to provide an updated patch? It really only needs some minor changes.
Comment 7 Paul Webster CLA 2014-03-27 09:26:40 EDT
Our last set of community contribution days for Luna is coming up.  Can you tweak your contribution?

PW
Comment 8 Cornel Izbasa CLA 2014-05-30 06:52:26 EDT
Really sorry, I completely forgot about this commit.
Is there anything I can do about it now?

Cornel
Comment 9 Dani Megert CLA 2014-05-30 10:54:11 EDT
(In reply to Cornel Izbasa from comment #8)
> Really sorry, I completely forgot about this commit.
> Is there anything I can do about it now?
> 
> Cornel

np. Just upload a new change so that we can consider it for 4.5.
Comment 10 Cornel Izbasa CLA 2014-05-31 07:32:45 EDT
Submitted update after review: https://git.eclipse.org/r/#/c/27641/

Thanks,
Cornel
Comment 11 Dani Megert CLA 2014-06-03 03:24:41 EDT
(In reply to Cornel Izbasa from comment #10)
> Submitted update after review: https://git.eclipse.org/r/#/c/27641/
> 
> Thanks,
> Cornel

Hi Cornel. Can you please upload this to the original Gerrit change, so that we can easily compare the patch sets? Simply use the same change id (I455d6ed55d906913bff27810303242a0a3df65e2) when committing the change and pushing to Gerrit.
Comment 12 Paul Webster CLA 2014-07-07 10:41:22 EDT
(In reply to Cornel Izbasa from comment #10)
> Submitted update after review: https://git.eclipse.org/r/#/c/27641/

Hi Cornel, could you update the patch? We can get this in early in Mars.

PW
Comment 13 Cornel Izbasa CLA 2014-07-07 15:41:32 EDT
I had already done it here (didn't post about it though): 
https://git.eclipse.org/r/#/c/20183/

Cheers,
Cornel
Comment 15 Cornel Izbasa CLA 2014-08-05 12:45:35 EDT
Thanks Dani and Lars!