Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420727

Summary:

Blank left pane in editor

Product:

[ECD] Orion

Reporter:

Silenio Quarti <Silenio_Quarti>

Component:

Client

Assignee:

Project Inbox <orion.client-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

malgorzata.tomczyk, simon_kaegi

Version:

4.0

Flags:

simon_kaegi: review+

Target Milestone:

4.0 RC3

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Silenio Quarti

2013-10-30 10:16:22 EDT

In Editor, select and open a project. Dropdown hamburger and select the Shell related link. In Shell page, dropdown hamburger and select Editor related link. Click the arrow up command in the editor page.

Requires the fix for bug#419973.

The navigator goes blank.

Comment 1 Silenio Quarti

2013-10-30 10:17:52 EDT

Created attachment 237065 [details]
fix

Comment 2 Malgorzata Janczarska

2013-10-30 11:37:10 EDT

The fix is good and it solves the problem, but was are the plans for "navigate" parameter? I got the feeling that we are planning to remove it completely. Right now it is not kept when we select a file or a folder, so after refresh the LHS changes to show the full workspace view. Just ignoring the "navigate" parameter would also fix the problem, but the application would act differently. It's debatable if better, but more consistent.

Comment 3 Silenio Quarti

2013-10-30 13:27:57 EDT

Reviewed with Simon. We found a couple a cases that needed work still.

When following the steps of comment#0, after clicking the arrow up, the navigator is focused on the project (showing the project content, not the root content).  This is not desirable, so we decided to remove the navigate parameter from the URL.

And here is another case where the left pane goes blank and the toolbar is duplicated.

1) Open the editor and click on a project to show the project nav.
2) Drop down the hamburger and click the Editor related link.

At this point, the left pane shows the navigator (sometimes it is blank) and the toolbar has the project nav commands and the mini nav commands showing.

The Editor related link should not show in the Editor page. This would avoid this problem.  But there is no easy way to add this to the validationProperties of that link.   We fixed it by ignoring the action, if the mini nav is not shown.

Comment 4 Silenio Quarti

2013-10-30 14:07:28 EDT

Forgot the link to the fix:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=R4.0RC3_maintenance&id=40c0cef47669962817f4b28e6dad1085c07796ef

Comment 5 Simon Kaegi

2013-10-30 15:48:35 EDT

Fixed in 4.0