Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 420722

Summary:	[KeyBindings] Key Assist popup doesn't work for most commands
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Dani Megert <daniel_megert>
Status:	VERIFIED FIXED	QA Contact:	Paul Elder <pelder.eclipse>
Severity:	major
Priority:	P3	CC:	daniel_megert, pwebster
Version:	4.4
Target Milestone:	4.4 M3
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	420742

Description Markus Keller

2013-10-30 09:41:24 EDT

The Key Assist popup is broken for most commands.

It only seems to work for commands in the "In Windows" context that don't care about what shell has focus (e.g. About or Show View).

But for most of the commands, a correct implementation must first close the popup and only then execute the command.

Fixing this bug would probably also solve bug 369860.

Comment 1 Dani Megert

2013-10-30 12:01:59 EDT

This is also broken in 4.3.x.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/

Comment 2 Dani Megert

2013-10-30 12:10:11 EDT

The fix does not help with bug 369860.

Filed bug 420742 to backport this to 4.3.2.

Comment 3 Paul Webster

2013-10-30 17:04:18 EDT

In 4.4.0.I20131030-1400

I tested the key assist dialog with commands like Run Junit Plug-in Test and Line End.  They seemed to work correctly in the workbench window.

PW

Comment 4 Dani Megert

2013-11-04 08:53:47 EST

(In reply to Dani Megert from comment #1)
> This is also broken in 4.3.x.
> 
> Fixed with
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=http://
> git.eclipse.org/c/jdt/eclipse.jdt.ui.git/

Wrong URL. Correct is:
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6c07c2033e1be50f163a326e31609d9d4323b4b6