Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 42066

Summary:

[preferences] "New Template" and "Edit Template" dialogs margin spacing

Product:

[Eclipse Project] JDT

Reporter:

Sebastian Davids <sdavids>

Component:

Text

Assignee:

JDT-Text-Inbox <jdt-text-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

daniel_megert

Version:

3.0

Target Milestone:

3.4 M4

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
fix	none
fix	none
screenshot showing the different spacings	none
on Windows	none

Description Sebastian Davids

2003-08-26 20:34:19 EDT

The spacing at the top, left and right should be the same as the spacing between
the OK button and the bottom.

Comment 1 Sebastian Davids

2005-04-05 07:15:46 EDT

Created attachment 19530 [details]
fix

Comment 2 Sebastian Davids

2005-04-05 08:27:01 EDT

Created attachment 19536 [details]
fix

Comment 3 Dani Megert

2007-11-06 05:03:03 EST

The dialog looks OK to me.

Comment 4 Sebastian Davids

2007-11-23 06:18:43 EST

Created attachment 83619 [details]
screenshot showing the different spacings

Comment 5 Sebastian Davids

2007-11-23 06:19:34 EST

see screenshot

Comment 6 Dani Megert

2007-11-23 06:31:03 EST

Where do you think the margin isn't ok? I can't see this in your image.

Comment 7 Sebastian Davids

2007-11-23 07:31:53 EST

Created attachment 83626 [details]
on Windows

take a look at the orange and the pink lines

Comment 8 Dani Megert

2007-11-23 08:29:58 EST

ok, got it. We normally don't set marginTop. Also, the spacing should be set:
==>
layout.marginHeight= 
    convertVerticalDLUsToPixels(IDialogConstants.VERTICAL_MARGIN);
layout.marginWidth= 
    convertHorizontalDLUsToPixels(IDialogConstants.HORIZONTAL_MARGIN);
layout.verticalSpacing= 
    convertVerticalDLUsToPixels(IDialogConstants.VERTICAL_SPACING);
layout.horizontalSpacing= 
    convertHorizontalDLUsToPixels(IDialogConstants.HORIZONTAL_SPACING);


In addition the EditTemplateDialog in Platform Text needs to be adjusted as well.

Fixed in HEAD.
Available in builds > N20071123-0010.