Bugzilla – Full Text Bug Listing
| Summary: | import local file... Choose File should allow picking multiple files, just like drag and drop does | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Adrian Aichner <adrian.aichner> |
| Component: | Client | Assignee: | Adrian Aichner <adrian.aichner> |
| Status: | RESOLVED FIXED | QA Contact: | Grant Gayed <grant_gayed> |
| Severity: | normal | ||
| Priority: | P3 | CC: | adrian.aichner, grant_gayed |
| Version: | 4.0 | Flags: | grant_gayed:
review+
|
| Target Milestone: | 5.0 M1 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Adrian Aichner
My fix is in https://github.com/anaran/orion.client/commit/a3579ed7bd9f1d6b00de73ad369fb111d2bd61db I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL https://github.com/anaran/orion.client/commit/cc14082169fa3725edd54aa08b3ab2f01b3f98c1 adds the multiple attribute, but only the first file is actually implemented so far. Will have a look tomorrow. OK, it's well into tomorrow around here. Following commit actually imported multiple files selected via the [Choose Files] dialog button and dialog box. Please review and merge. https://github.com/anaran/orion.client/commit/d2d352bd69b9dc84b187a331deba275215632c50 Regards, Adrian (In reply to Adrian Aichner from comment #2) > https://github.com/anaran/orion.client/commit/ > cc14082169fa3725edd54aa08b3ab2f01b3f98c1 > > adds the multiple attribute, but only the first file is actually implemented > so far. > > Will have a look tomorrow. Reviewed, the change looks good and follows the existing pattern for importing local files that are dropped in the "Drag a file here" box, so pushed > 20131104. There seems to be a general problem with local imports, but this is not related to this change. Will log a separate report for this. The importing problem I mentioned is already logged as bug 420884. Closing report as FIXED. |